From 442c01610e889769a5acb8642d7e732b186afcb7 Mon Sep 17 00:00:00 2001 From: Amirreza Ghajar Date: Wed, 4 Oct 2023 01:01:00 +0330 Subject: [PATCH 1/9] Update user.js adding get the transferable function to the service --- lib/user.js | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/lib/user.js b/lib/user.js index ce6c51a..26cd071 100644 --- a/lib/user.js +++ b/lib/user.js @@ -113,6 +113,21 @@ User.innerTransfer = async function(params) { return result.data } +/* + Get the Transferable + GET /api/v1/accounts/transferable + params = { + currency: string, + type: string, //MAIN, TRADE, MARGIN or ISOLATED + tag: string, //[optional] + } +*/ +User.getTheTransferable = async function(params){ + let endpoint = '/api/v1/accounts/transferable' + let url = this.baseURL + endpoint + let result = await axios.get(url,this.sign(endpoint, params, 'GET')) + return result.data +} /* Create Deposit Address POST /api/v1/deposit-addresses From edfaf966bb9098c4fbd328812c1d25525cf727b6 Mon Sep 17 00:00:00 2001 From: Amirreza Ghajar Date: Wed, 4 Oct 2023 14:14:28 +0330 Subject: [PATCH 2/9] Update user.js --- lib/user.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/user.js b/lib/user.js index 26cd071..617f2ca 100644 --- a/lib/user.js +++ b/lib/user.js @@ -123,9 +123,9 @@ User.innerTransfer = async function(params) { } */ User.getTheTransferable = async function(params){ - let endpoint = '/api/v1/accounts/transferable' + let endpoint = `/api/v1/accounts/transferable?currency=${params.currency}&type=${params.type}` let url = this.baseURL + endpoint - let result = await axios.get(url,this.sign(endpoint, params, 'GET')) + let result = await axios.get(url,this.sign(endpoint, {}, 'GET')) return result.data } /* From 58decb2c03406bb48a34c8e9441f10ab6a3193bd Mon Sep 17 00:00:00 2001 From: amirrezagh75 Date: Wed, 11 Oct 2023 13:40:39 +0330 Subject: [PATCH 3/9] adding a new function for geting trade Fee --- lib/trade.js | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/lib/trade.js b/lib/trade.js index c08e24f..dcf1951 100644 --- a/lib/trade.js +++ b/lib/trade.js @@ -32,6 +32,18 @@ Trade.placeOrder = async function (params) { return result.data } +/** + * Get trade fee + * GET /api/v1/trade-fees + * @param {String} params - give a pair like: BTC-USDT + * @returns {Object} {makerFeeRate: String, takerFeeRate: String} + */ +Trade.tradeFee = async (params)=>{ + let endpoint = `?symbols=${params}` + let url = this.baseURL + endpoint + let result = await axios.get(url,this.sign(endpoint, {}, 'GET')) + return result.data +} /* Cancel an order DELETE /api/v1/orders/ From 002246e6b482143d509910be090ce8e4e9f6b9e4 Mon Sep 17 00:00:00 2001 From: amirrezagh75 Date: Wed, 11 Oct 2023 13:48:01 +0330 Subject: [PATCH 4/9] updating package version --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 161c39d..8543638 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "kucoin-node-api", - "version": "2.1.5", + "version": "2.1.6", "description": "Node.js KuCoin Cryptocurrency Exchange v2 API Wrapper/SDK", "main": "kucoin.js", "scripts": { From 09c14dc79d0f8df555315435e303f664f8b52cc2 Mon Sep 17 00:00:00 2001 From: Amirreza Ghajar Date: Sat, 14 Oct 2023 13:21:00 +0330 Subject: [PATCH 5/9] Create npm-publish.yml --- .github/workflows/npm-publish.yml | 33 +++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) create mode 100644 .github/workflows/npm-publish.yml diff --git a/.github/workflows/npm-publish.yml b/.github/workflows/npm-publish.yml new file mode 100644 index 0000000..6cdebaf --- /dev/null +++ b/.github/workflows/npm-publish.yml @@ -0,0 +1,33 @@ +# This workflow will run tests using node and then publish a package to GitHub Packages when a release is created +# For more information see: https://docs.github.com/en/actions/publishing-packages/publishing-nodejs-packages + +name: Node.js Package + +on: + release: + types: [created] + +jobs: + build: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v3 + - uses: actions/setup-node@v3 + with: + node-version: 16 + - run: npm ci + - run: npm test + + publish-npm: + needs: build + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v3 + - uses: actions/setup-node@v3 + with: + node-version: 16 + registry-url: https://registry.npmjs.org/ + - run: npm ci + - run: npm publish + env: + NODE_AUTH_TOKEN: ${{secrets.npm_token}} From c1739bc86db2a6f16cfa933d3f223be7de17cc4d Mon Sep 17 00:00:00 2001 From: amirrezagh75 Date: Sat, 14 Oct 2023 14:38:54 +0330 Subject: [PATCH 6/9] editing function's type into ES5 --- lib/trade.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/trade.js b/lib/trade.js index dcf1951..943e24f 100644 --- a/lib/trade.js +++ b/lib/trade.js @@ -38,7 +38,7 @@ Trade.placeOrder = async function (params) { * @param {String} params - give a pair like: BTC-USDT * @returns {Object} {makerFeeRate: String, takerFeeRate: String} */ -Trade.tradeFee = async (params)=>{ +Trade.tradeFee = async function (params) { let endpoint = `?symbols=${params}` let url = this.baseURL + endpoint let result = await axios.get(url,this.sign(endpoint, {}, 'GET')) From f186b98c30aade0c53964a61f14dbc246b50e5d2 Mon Sep 17 00:00:00 2001 From: amirrezagh75 Date: Sat, 14 Oct 2023 14:55:32 +0330 Subject: [PATCH 7/9] editing endpoint address in "tradeFee" function --- lib/trade.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/trade.js b/lib/trade.js index 943e24f..5a7d003 100644 --- a/lib/trade.js +++ b/lib/trade.js @@ -39,7 +39,7 @@ Trade.placeOrder = async function (params) { * @returns {Object} {makerFeeRate: String, takerFeeRate: String} */ Trade.tradeFee = async function (params) { - let endpoint = `?symbols=${params}` + let endpoint = `/api/v1/trade-fees?symbols=${params}` let url = this.baseURL + endpoint let result = await axios.get(url,this.sign(endpoint, {}, 'GET')) return result.data From af877c1f6547856e08dd495a1920912694d22925 Mon Sep 17 00:00:00 2001 From: amirrezagh75 Date: Sat, 14 Oct 2023 15:47:58 +0330 Subject: [PATCH 8/9] updating getSymbols end point url into kucoin api v2 --- lib/market.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/market.js b/lib/market.js index d36f078..df19660 100644 --- a/lib/market.js +++ b/lib/market.js @@ -10,9 +10,9 @@ const Market = {} Market.getSymbols = async function(market = "") { let endpoint = "" if (market != "") { - endpoint = `/api/v1/symbols?market=${market}` + endpoint = `/api/v2/symbols?market=${market}` } else { - endpoint = "/api/v1/symbols" + endpoint = "/api/v2/symbols" } let url = this.baseURL + endpoint let result = await axios.get(url) From eaeaa51d513351ed7b91878ccbcb153452bb2dc1 Mon Sep 17 00:00:00 2001 From: amirrezagh75 Date: Sat, 14 Oct 2023 17:30:37 +0330 Subject: [PATCH 9/9] changing get symbols url into v1 of api --- lib/market.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/market.js b/lib/market.js index df19660..d36f078 100644 --- a/lib/market.js +++ b/lib/market.js @@ -10,9 +10,9 @@ const Market = {} Market.getSymbols = async function(market = "") { let endpoint = "" if (market != "") { - endpoint = `/api/v2/symbols?market=${market}` + endpoint = `/api/v1/symbols?market=${market}` } else { - endpoint = "/api/v2/symbols" + endpoint = "/api/v1/symbols" } let url = this.baseURL + endpoint let result = await axios.get(url)