chore: remove CODEOWNERS #307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> [Code owners are automatically requested for review when someone opens a pull request that modifies code that they own.](https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners#about-code-owners) Currently this file marks the maintainers as owners of the project. This is both redundant and annoying because (as per above) it means that the maintainers are forcibly added as a reviewer to every PR; meaning that maintainers are forcibly spammed with notifications. Adding as a reviewer forces maintainers to be "participating" in every PR - which overrides any other notification settings one might set on the repo. If we had owners for individual parts of the project - then CODEOWNERS would be desirable, but as it stands it's just a negative, IMO.
aladdin-add
approved these changes
Sep 12, 2022
This was referenced Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently this file marks the maintainers as owners of the project.
This is both redundant and annoying because (as per above) it means that the maintainers are forcibly added as a reviewer to every PR; meaning that maintainers are forcibly spammed with notifications.
Adding as a reviewer forces maintainers to be "participating" in every PR - which overrides any other notification settings one might set on the repo.
If we had owners for individual parts of the project - then CODEOWNERS would be desirable, but as it stands it's just a negative, IMO.