Skip to content

Commit e8f0d63

Browse files
committed
chore: a few review suggestions
1 parent 7b96327 commit e8f0d63

File tree

3 files changed

+5
-10
lines changed

3 files changed

+5
-10
lines changed

.github/workflows/CI.yml

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -31,15 +31,12 @@ jobs:
3131
strategy:
3232
matrix:
3333
os: [ubuntu-latest, windows-latest, macOS-latest]
34-
eslint: [8.x]
34+
eslint: [8.x, "9.0.0-alpha.0"]
3535
node: [18.x, 20.x]
3636
include:
3737
- os: ubuntu-latest
3838
node: "21.x"
3939
eslint: "8.x"
40-
- os: ubuntu-latest
41-
node: "20.x"
42-
eslint: "9.0.0-alpha.0"
4340
runs-on: ${{ matrix.os }}
4441
steps:
4542
- name: Checkout
@@ -51,7 +48,9 @@ jobs:
5148
with:
5249
node-version: ${{ matrix.node }}
5350
- name: Install Packages
54-
run: npm install
51+
run:
52+
npm i npm@latest -g # use latest npm
53+
npm install
5554
- name: Install ESLint ${{ matrix.eslint }}
5655
run: |
5756
npm install --no-save --force eslint@${{ matrix.eslint }}

tests/eslint-rule-tester.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,7 @@ const globals = require("globals")
1111
// greater than or equal to ESLint v9
1212
exports.gteEslintV9 = +eslintVersion.split(".")[0] >= 9
1313

14-
exports.FlatRuleTester = exports.gteEslintV9
15-
? RuleTester
16-
: unofficialApis.FlatRuleTester
14+
exports.FlatRuleTester = exports.gteEslintV9 ? RuleTester : FlatRuleTester
1715

1816
// to support the `env:{ es6: true, node: true}` rule-tester (env has been away in flat config.)
1917
// * enabled by default as it's most commonly used in the package.

tests/lib/rules/no-unpublished-require.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
"use strict"
66

77
const path = require("path")
8-
const globals = require("globals")
98
const RuleTester = require("#eslint-rule-tester").RuleTester
109
const rule = require("../../../lib/rules/no-unpublished-require")
1110

@@ -182,7 +181,6 @@ ruleTester.run("no-unpublished-require", rule, {
182181
{
183182
filename: fixture("1/test.js"),
184183
code: "require(`foo${bar}`);",
185-
languageOptions: { globals: globals.node },
186184
},
187185

188186
// Should work fine if the filename is relative.

0 commit comments

Comments
 (0)