Add n/prefer-node-protocol rule #183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scagood
reviewed
Feb 11, 2024
scagood
left a comment
scagood
left a comment
There was a problem hiding this comment.
Thank you for the contribution, this is a great rule to add to eslint-plugin-n!
Thank you for also adding good looking docs :)
yinm
commented
Feb 12, 2024
Author
yinm
left a comment
yinm
left a comment
There was a problem hiding this comment.
Thank you for your review 🙏
I tried to reflect your review, so could you please review it again?
scagood
reviewed
Feb 12, 2024
scagood
reviewed
Feb 12, 2024
scagood
approved these changes
Feb 13, 2024
aladdin-add
reviewed
Feb 18, 2024
lib/rules/prefer-node-protocol.js
Outdated
| docs: { | ||
| description: | ||
| "enforce using the `node:` protocol when importing Node.js builtin modules.", | ||
| recommended: true, |
There was a problem hiding this comment.
the recommended config changes would be a breaking change.
Suggested change
| recommended: true, | |
| recommended: false, |
Author
There was a problem hiding this comment.
Thank you for your review 🙏
I fixed it.
aladdin-add
pushed a commit
that referenced
this pull request
Feb 22, 2024
* feat: add `n/prefer-node-protocol` rule * feat: support `require` function * docs: add `export` examples * feat: enable or disable this rule by supported Node.js version * refactor: use `visit-require` and `visit-import` * fix: avoid type error by non-string types * refactor: use `moduleStyle` for simplicity * chore: update to false for avoiding a breaking change
This was referenced May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #77
I tried porting the rules and tests of https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/prefer-node-protocol.md.