Skip to content

Conversation

@aladdin-add
Copy link

No description provided.

@aladdin-add aladdin-add force-pushed the feat/no-deprecated-api-removed branch 3 times, most recently from fa74be9 to 74ab0d3 Compare April 11, 2024 07:04
Copy link

@scagood scagood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

I assume the error is the missing global? I wonder if there is a way to have this error without the global being defined?

deprecated:
"{{name}} was deprecated since v{{version}}{{replace}}.",
removed:
"{{name}} was deprecated since v{{version}}, and removed in v{{removed}}.",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be worth including replace here still

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, we can add it in another PR.

@aladdin-add aladdin-add force-pushed the feat/no-deprecated-api-removed branch from 74ab0d3 to 42ac0a6 Compare April 17, 2024 09:41
@aladdin-add aladdin-add self-assigned this Apr 24, 2024
@aladdin-add aladdin-add force-pushed the feat/no-deprecated-api-removed branch from c0c78f1 to 009f422 Compare April 29, 2024 06:53
@aladdin-add aladdin-add marked this pull request as ready for review April 29, 2024 06:53
@aladdin-add aladdin-add merged commit 36fd35d into master Apr 29, 2024
@aladdin-add aladdin-add deleted the feat/no-deprecated-api-removed branch April 29, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants