fix: tcp_output() should always be called after tcp_write(), does not break nagle (+ doc) (#5172)

d-a-v · web-flow · commit 775eb9b34375 · 2018-09-26T23:56:01.000+02:00
diff --git a/libraries/ESP8266WiFi/src/include/ClientContext.h b/libraries/ESP8266WiFi/src/include/ClientContext.h
@@ -508,10 +508,11 @@ class ClientContext
             }
         }
 
-        if (has_written && (_sync || tcp_nagle_disabled(_pcb)))
+        if (has_written)
         {
-            // handle no-Nagle manually because of TCP_WRITE_FLAG_MORE
             // lwIP's tcp_output doc: "Find out what we can send and send it"
+            // *with respect to Nagle*
+            // more insights: https://lists.gnu.org/archive/html/lwip-users/2017-11/msg00134.html
             tcp_output(_pcb);
         }
 

Original file line number	Diff line number	Diff line change
`@@ -508,10 +508,11 @@ class ClientContext`
`508`	`508`	`}`
`509`	`509`	`}`
`510`	`510`
`511`		`- if (has_written && (_sync \|\| tcp_nagle_disabled(_pcb)))`
	`511`	`+ if (has_written)`
`512`	`512`	`{`
`513`		`- // handle no-Nagle manually because of TCP_WRITE_FLAG_MORE`
`514`	`513`	`// lwIP's tcp_output doc: "Find out what we can send and send it"`
	`514`	`+ // with respect to Nagle`
	`515`	`+ // more insights: https://lists.gnu.org/archive/html/lwip-users/2017-11/msg00134.html`
`515`	`516`	`tcp_output(_pcb);`
`516`	`517`	`}`
`517`	`518`