-
Notifications
You must be signed in to change notification settings - Fork 187
feat(t8n): Support evmone's --opcode.count option
#1956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8e38881 to
59cefc0
Compare
59cefc0 to
5443996
Compare
danceratopz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @marioevz this looks very good to me.
Love the addition to the fixture _info field:

As a follow-up PR, should we diff the expected opcode count (as defined by the bytecode) with that from evmone-t8n if different during filling? Or did you consider that going too far?
|
This is extremely helpful in some situations especially that it is being added to the fixtures info field. For benchmarks esp. regarding gas pricing it would be super helpful to include this in the fixtures by default (so also on the releases). Could this be done? |
spencer-tb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one! Working from my side too. LGTM
🗒️ Description
Adds support for the
--opcode.countparameter added in ipsilon/evmone#1274.This is still in draft but already helped on #1935 to get the diffs in opcode counts from before and after the PR.
🔗 Related Issues or PRs
Closes #1852
t8ninterface #1852✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlinttype(scope):.mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.@ported_frommarker.