eth/api: fix potential nil deref in AccountRange (#21710)

aaronbuchwald · web-flow · commit 3e82c9ef67b9 · 2020-10-20T20:19:21.000+02:00
* Fix potential nil pointer error when neither block number nor hash is specified to accountRange

* Update error description
diff --git a/eth/api.go b/eth/api.go
@@ -389,6 +389,8 @@ func (api *PublicDebugAPI) AccountRange(blockNrOrHash rpc.BlockNumberOrHash, sta
 		if err != nil {
 			return state.IteratorDump{}, err
 		}
+	} else {
+		return state.IteratorDump{}, errors.New("either block number or block hash must be specified")
 	}
 
 	if maxResults > AccountRangeMaxResults || maxResults <= 0 {

Original file line number	Diff line number	Diff line change
`@@ -389,6 +389,8 @@ func (api *PublicDebugAPI) AccountRange(blockNrOrHash rpc.BlockNumberOrHash, sta`
`389`	`389`	`if err != nil {`
`390`	`390`	`return state.IteratorDump{}, err`
`391`	`391`	`}`
	`392`	`+ } else {`
	`393`	`+ return state.IteratorDump{}, errors.New("either block number or block hash must be specified")`
`392`	`394`	`}`
`393`	`395`
`394`	`396`	`if maxResults > AccountRangeMaxResults \|\| maxResults <= 0 {`