From 1e36e2502f0b1775afafb60d07e2c96a0687abeb Mon Sep 17 00:00:00 2001 From: ucwong Date: Wed, 8 Nov 2023 02:53:57 +0800 Subject: [PATCH 1/2] eth/filter : reused the error msg for invalid block range --- eth/filters/filter.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/eth/filters/filter.go b/eth/filters/filter.go index a5750c19348..83e3284a2b5 100644 --- a/eth/filters/filter.go +++ b/eth/filters/filter.go @@ -114,7 +114,7 @@ func (f *Filter) Logs(ctx context.Context) ([]*types.Log, error) { // special case for pending logs if beginPending && !endPending { - return nil, errors.New("invalid block range") + return nil, errInvalidBlockRange } // Short-cut if all we care about is pending logs From 7ec4f9960e73854ee8a76fbbda6df058e18afe79 Mon Sep 17 00:00:00 2001 From: ucwong Date: Mon, 20 Nov 2023 18:27:16 +0800 Subject: [PATCH 2/2] eth/filters : filter test fix --- eth/filters/filter_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/eth/filters/filter_test.go b/eth/filters/filter_test.go index 4e09a9038b3..1db917c960e 100644 --- a/eth/filters/filter_test.go +++ b/eth/filters/filter_test.go @@ -353,7 +353,7 @@ func TestFilters(t *testing.T) { }, { f: sys.NewRangeFilter(int64(rpc.PendingBlockNumber), int64(rpc.LatestBlockNumber), nil, nil), - err: "invalid block range", + err: errInvalidBlockRange.Error(), }, } { logs, err := tc.f.Logs(context.Background())