Wait until process exit in esbuild.stop() #3897
Open
+15
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes `esbuild.stop()` to only resolve the returned promise when the child process has actually exited. This is useful for when you have some resource sanitization in place that checks that the child process has actually been closed.
marvinhagemeister
approved these changes
Aug 27, 2024
|
Ping? :) I just spent a while trying to figure out what was keeping my process alive longer than expected, and I noticed that ESBuild's process is still alive even after that the promise returned by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes
esbuild.stop()to only resolve the returned promise when the child process has actually exited.This is useful for when you have some resource sanitization in place that checks that the child process has actually been closed.