update number renamer to avoid collisions in parent scopes #3949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
findNameUse looks across all parent scopes to determine if a name has been used. However, when findUnusedName begins trying to find an unused name, it uses only the nameCount in the current scope, which could require incrementing the name many times before avoiding collisions with a parent scope. With this change, findUnusedName will begin incrementing using the maximum nameCount across all scopes.
I have a bit of an unusual use case where I'm using esbuild in the browser with a plugin to fetch imports like https://cdn.jsdelivr.net/npm/react/+esm. Because these are already minified, there can be a very large number of name collisions at the topmost scope. This change speeds up builds for my use case by 2-3x.