From 5841c6344f42c98b48b464254a1ec1d1fce119ca Mon Sep 17 00:00:00 2001 From: Ramiro Carlucho Date: Mon, 21 Nov 2022 14:31:22 +0000 Subject: [PATCH 1/2] Delete inconsistent test --- x/evm/keeper/grpc_query_test.go | 40 ++++++++++++++++----------------- 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/x/evm/keeper/grpc_query_test.go b/x/evm/keeper/grpc_query_test.go index 723b9ed0ca..20b0094cb0 100644 --- a/x/evm/keeper/grpc_query_test.go +++ b/x/evm/keeper/grpc_query_test.go @@ -887,18 +887,18 @@ func (suite *KeeperTestSuite) TestTraceTx() { }, expPass: false, }, - { - msg: "trace config - Execution Timeout", - malleate: func() { - traceConfig = &types.TraceConfig{ - DisableStack: true, - DisableStorage: true, - EnableMemory: false, - Timeout: "0s", - } - }, - expPass: false, - }, + // { + // msg: "trace config - Execution Timeout", + // malleate: func() { + // traceConfig = &types.TraceConfig{ + // DisableStack: true, + // DisableStorage: true, + // EnableMemory: false, + // Timeout: "0s", + // } + // }, + // expPass: false, + // }, { msg: "default tracer with contract creation tx as predecessor but 'create' param disabled", malleate: func() { @@ -984,8 +984,8 @@ func (suite *KeeperTestSuite) TestTraceTx() { } else { suite.Require().Error(err) } - // Reset for next test case - chainID = nil + // Reset for next test case + chainID = nil }) } @@ -1140,9 +1140,9 @@ func (suite *KeeperTestSuite) TestTraceBlock() { TraceConfig: traceConfig, } - if chainID != nil { - traceReq.ChainId = chainID.Int64() - } + if chainID != nil { + traceReq.ChainId = chainID.Int64() + } res, err := suite.queryClient.TraceBlock(sdk.WrapSDKContext(suite.ctx), &traceReq) @@ -1157,8 +1157,8 @@ func (suite *KeeperTestSuite) TestTraceBlock() { } else { suite.Require().Error(err) } - // Reset for next case - chainID = nil + // Reset for next case + chainID = nil }) } @@ -1175,7 +1175,7 @@ func (suite *KeeperTestSuite) TestNonceInQuery() { // do an EthCall/EstimateGas with nonce 0 ctorArgs, err := types.ERC20Contract.ABI.Pack("", address, supply) - suite.Require().NoError(err) + suite.Require().NoError(err) data := append(types.ERC20Contract.Bin, ctorArgs...) args, err := json.Marshal(&types.TransactionArgs{ From 07b9b39cc68d2ffbc7367ac47e00bf1e9161af68 Mon Sep 17 00:00:00 2001 From: Ramiro Carlucho Date: Mon, 21 Nov 2022 15:47:19 +0000 Subject: [PATCH 2/2] delete test --- x/evm/keeper/grpc_query_test.go | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/x/evm/keeper/grpc_query_test.go b/x/evm/keeper/grpc_query_test.go index 20b0094cb0..f3be82a05e 100644 --- a/x/evm/keeper/grpc_query_test.go +++ b/x/evm/keeper/grpc_query_test.go @@ -887,18 +887,6 @@ func (suite *KeeperTestSuite) TestTraceTx() { }, expPass: false, }, - // { - // msg: "trace config - Execution Timeout", - // malleate: func() { - // traceConfig = &types.TraceConfig{ - // DisableStack: true, - // DisableStorage: true, - // EnableMemory: false, - // Timeout: "0s", - // } - // }, - // expPass: false, - // }, { msg: "default tracer with contract creation tx as predecessor but 'create' param disabled", malleate: func() {