Skip to content

Commit 0aa8ed6

Browse files
JoshuaGrossfacebook-github-bot
authored andcommitted
Remove useless Mounting diagnostic error
Summary: While in theory we should never delete views before removing them from the hierarchy, there are some exceptions: (1) Some mysterious cases that don't seem like bugs, but where the child still seems to keep a reference to the parent: (2) When deleting views as part of stopSurface. On #1: in the past we had issues when we assumed that ViewManager.getChildCount() would return an accurate count. Sometimes it's just... wrong. Here, I've found at least one case where a View still has a parent after it's removed from the View hierarchy. I assume this is undocumented Android behavior or an Android bug, but either way, there's nothing I can do about it. On #2: there are valid cases where we want to delete a View without explicitly removing it from the View hierarchy (it will eventually be removed from the hierarchy when the Root view is unmounted, but it may still be "in" a View hierarchy when it's deleted). Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D22321374 fbshipit-source-id: 9667bbe778c418f0216550638dc26ca48a58e5fa
1 parent 3c3f8ca commit 0aa8ed6

File tree

1 file changed

+0
-9
lines changed

1 file changed

+0
-9
lines changed

ReactAndroid/src/main/java/com/facebook/react/fabric/mounting/MountingManager.java

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -455,15 +455,6 @@ public void deleteView(int reactTag) {
455455
View view = viewState.mView;
456456

457457
if (view != null) {
458-
ViewParent parentView = view.getParent();
459-
460-
if (parentView != null) {
461-
ReactSoftException.logSoftException(
462-
TAG,
463-
new IllegalStateException(
464-
"Warning: Deleting view that is still attached to parent: [" + reactTag + "]"));
465-
}
466-
467458
dropView(view);
468459
} else {
469460
mTagToViewState.remove(reactTag);

0 commit comments

Comments
 (0)