Enable hermes debugger on all build variants (#33)

Author: Kudo

packages/react-native/ReactAndroid/hermes-engine/build.gradle.kts

@@ -301,8 +301,8 @@ android {
         cmake {
           arguments(
               "-DCMAKE_BUILD_TYPE=MinSizeRel",
-              // For release builds, we don't want to enable the Hermes Debugger.
-              "-DHERMES_ENABLE_DEBUGGER=False")
+              // For Expo Go, we have to enable debugging even on release builds.
+              "-DHERMES_ENABLE_DEBUGGER=True")
         }
       }
     }

packages/react-native/ReactAndroid/src/main/jni/react/hermes/reactexecutor/CMakeLists.txt

@@ -15,6 +15,13 @@ add_library(hermes_executor
         OBJECT
         ${hermes_executor_SRC}
 )
+target_compile_options(
+        hermes_executor
+        PRIVATE
+        -DHERMES_ENABLE_DEBUGGER=1
+        -std=c++20
+        -fexceptions
+)
 target_merge_so(hermes_executor)
 target_include_directories(hermes_executor PRIVATE .)
 target_link_libraries(

packages/react-native/ReactAndroid/src/main/jni/react/runtime/hermes/jni/CMakeLists.txt

@@ -15,6 +15,14 @@ add_library(hermesinstancejni
         OBJECT
         ${hermes_instance_jni_SRC}
 )
+target_compile_options(
+        hermesinstancejni
+        PRIVATE
+        -DHERMES_ENABLE_DEBUGGER=1
+        -std=c++20
+        -fexceptions
+)
+
 target_include_directories(hermesinstancejni PRIVATE .)
 target_merge_so(hermesinstancejni)
 

packages/react-native/ReactAndroid/src/main/jni/react/runtime/jni/CMakeLists.txt

@@ -18,7 +18,13 @@ add_library(rninstance
 
 target_compile_reactnative_options(rninstance PRIVATE)
 if(${CMAKE_BUILD_TYPE} MATCHES Debug OR REACT_NATIVE_DEBUG_OPTIMIZED)
-  target_compile_options(rninstance PRIVATE -DHERMES_ENABLE_DEBUGGER=1)
+  target_compile_options(
+        rninstance
+        PRIVATE
+        -DHERMES_ENABLE_DEBUGGER=1
+        -std=c++20
+        -fexceptions
+  )
 endif ()
 
 target_merge_so(rninstance)

packages/react-native/ReactCommon/hermes/executor/CMakeLists.txt

@@ -37,5 +37,6 @@ else()
                 hermes_executor_common
                 PRIVATE
                 -DNDEBUG
+                -DHERMES_ENABLE_DEBUGGER=1
         )
 endif()

packages/react-native/ReactCommon/hermes/inspector-modern/CMakeLists.txt

@@ -23,6 +23,14 @@ if(${CMAKE_BUILD_TYPE} MATCHES Debug OR REACT_NATIVE_DEBUG_OPTIMIZED)
                 PRIVATE
                 -DHERMES_ENABLE_DEBUGGER=1
         )
+else()
+        # Expo Go requires debugging on release builds
+        target_compile_options(
+                hermes_inspector_modern
+                PRIVATE
+                # Expo Go requires debugging on release builds
+                -DHERMES_ENABLE_DEBUGGER=1
+        )
 endif()
 
 target_include_directories(hermes_inspector_modern PUBLIC ${REACT_COMMON_DIR})

packages/react-native/ReactCommon/react/runtime/CMakeLists.txt

@@ -17,7 +17,13 @@ add_library(bridgeless
 )
 target_compile_reactnative_options(bridgeless PRIVATE)
 if(${CMAKE_BUILD_TYPE} MATCHES Debug OR REACT_NATIVE_DEBUG_OPTIMIZED)
-  target_compile_options(bridgeless PRIVATE -DHERMES_ENABLE_DEBUGGER=1)
+  target_compile_options(
+        bridgeless
+        PRIVATE
+        -DHERMES_ENABLE_DEBUGGER=1
+        -std=c++20
+        -fexceptions
+  )
 endif ()
 target_include_directories(bridgeless PUBLIC .)
 

packages/react-native/sdks/hermes-engine/hermes-engine.podspec

@@ -22,6 +22,9 @@ end
 package = JSON.parse(File.read(File.join(react_native_path, "package.json")))
 version = package['version']
 
+# Force building Hermes from source because Expo Go requires customized Hermes build
+ENV['RCT_BUILD_HERMES_FROM_SOURCE'] = 'true'
+
 source_type = hermes_source_type(version, react_native_path)
 source = podspec_source(source_type, version, react_native_path)
 

packages/react-native/sdks/hermes-engine/utils/build-apple-framework.sh

@@ -72,7 +72,8 @@ function configure_apple_framework {
   if [[ $BUILD_TYPE == "Debug" ]]; then
     enable_debugger="true"
   else
-    enable_debugger="false"
+    # Expo Go requires debugging on release build
+    enable_debugger="true"
   fi
   if [[ $BUILD_TYPE == "Debug" ]]; then
     # JS developers aren't VM developers.

packages/react-native/sdks/hermes-engine/utils/build-hermes-xcode.sh

@@ -36,7 +36,8 @@ function get_deployment_target {
     echo "${IPHONEOS_DEPLOYMENT_TARGET}"
 }
 
-enable_debugger="false"
+# Expo Go requires debugging on release build
+enable_debugger="true"
 if [[ "$CONFIGURATION" = *Debug* ]]; then
   enable_debugger="true"
 fi