Skip to content

Commit b8c29af

Browse files
authored
Fix codegen resolution error when node_modules has different version (#29)
# Why fix android client build error for expo/expo#15914 when different react-native version between `node_modules/react-native` and `react-native-lab/react-native`. # How use the `react-native-codegen` from the same repository.
1 parent c2123c9 commit b8c29af

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

scripts/generate-specs-cli.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,8 @@
1111

1212
let RNCodegen;
1313
try {
14-
RNCodegen = require('react-native-codegen/lib/generators/RNCodegen.js');
14+
// Use the `react-native-codegen` from the `react-native` repository instead of node_modules.
15+
RNCodegen = require(__dirname + '/../packages/react-native-codegen/lib/generators/RNCodegen.js');
1516
} catch (e) {
1617
RNCodegen = require('../packages/react-native-codegen/lib/generators/RNCodegen.js');
1718
if (!RNCodegen) {

scripts/generate-specs.sh

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,8 @@ main() {
6262
exit 1
6363
fi
6464

65-
CODEGEN_PATH=$("$NODE_BINARY" -e "console.log(require('path').dirname(require.resolve('react-native-codegen/package.json')))")
65+
# Use the `react-native-codegen` from the `react-native` repository instead of node_modules.
66+
CODEGEN_PATH="$RN_DIR/packages/react-native-codegen"
6667

6768
# Special case for running CodeGen from source: build it
6869
if [ ! -d "$CODEGEN_PATH/lib" ]; then

0 commit comments

Comments
 (0)