Make RCTCxxBridge not care about the actual protocol implemented, only the method used

sjchmiela · Kudo · commit d1dd984bc081 · 2021-07-19T23:57:07.000+08:00
diff --git a/React/CxxBridge/RCTCxxBridge.mm b/React/CxxBridge/RCTCxxBridge.mm
@@ -392,7 +392,7 @@ - (void)start
   // Prepare executor factory (shared_ptr for copy into block)
   std::shared_ptr<JSExecutorFactory> executorFactory;
   if (!self.executorClass) {
-    if ([self.delegate conformsToProtocol:@protocol(RCTCxxBridgeDelegate)]) {
+    if ([self.delegate respondsToSelector:@selector(jsExecutorFactoryForBridge:)]) {
       id<RCTCxxBridgeDelegate> cxxDelegate = (id<RCTCxxBridgeDelegate>)self.delegate;
       executorFactory = std::make_shared<JSCExecutorFactory>(*reinterpret_cast<JSCExecutorFactory *>([cxxDelegate jsExecutorFactoryForBridge:self]));
     }

Original file line number	Diff line number	Diff line change
`@@ -392,7 +392,7 @@ - (void)start`
`392`	`392`	`// Prepare executor factory (shared_ptr for copy into block)`
`393`	`393`	`std::shared_ptr<JSExecutorFactory> executorFactory;`
`394`	`394`	`if (!self.executorClass) {`
`395`		`- if ([self.delegate conformsToProtocol:@protocol(RCTCxxBridgeDelegate)]) {`
	`395`	`+ if ([self.delegate respondsToSelector:@selector(jsExecutorFactoryForBridge:)]) {`
`396`	`396`	`id<RCTCxxBridgeDelegate> cxxDelegate = (id<RCTCxxBridgeDelegate>)self.delegate;`
`397`	`397`	`executorFactory = std::make_shared<JSCExecutorFactory>(reinterpret_cast<JSCExecutorFactory >([cxxDelegate jsExecutorFactoryForBridge:self]));`
`398`	`398`	`}`