Skip to content

Conversation

@dee-kap
Copy link
Contributor

@dee-kap dee-kap commented Apr 22, 2015

Move the code which flattens an array to an external package. That's it for this simple change.

@dougwilson dougwilson added the pr label Apr 23, 2015
@dougwilson
Copy link
Contributor

Thanks, though can you change it to use the array-flatten module instead, since that's what we use in the router module?

@dougwilson dougwilson self-assigned this Apr 23, 2015
@dee-kap
Copy link
Contributor Author

dee-kap commented Apr 23, 2015

I don't see array-flatten being used anywhere.

@dougwilson
Copy link
Contributor

@dee-kap
Copy link
Contributor Author

dee-kap commented Apr 23, 2015

@dougwilson I have replaced arr-util with array-flatten.

@dougwilson dougwilson added the 4.x label May 4, 2015
dougwilson pushed a commit that referenced this pull request May 21, 2015
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

array-flatten is missing from package.json

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would be the best way to push this fix through?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typically you would just add it to your package.json and just push a new commit to the branch that this PR came from :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, nevermind, looks like I already merged this commit into the 4.13 branch :) Looks like you need take no action at all :D

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@dougwilson dougwilson mentioned this pull request Jun 19, 2015
6 tasks
@dougwilson dougwilson added this to the 4.13 milestone Jun 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants