-
-
Notifications
You must be signed in to change notification settings - Fork 21.5k
Use external package to flatten an array in utils #2624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks, though can you change it to use the |
|
I don't see array-flatten being used anywhere. |
|
@dougwilson I have replaced arr-util with array-flatten. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
array-flatten is missing from package.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What would be the best way to push this fix through?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typically you would just add it to your package.json and just push a new commit to the branch that this PR came from :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, nevermind, looks like I already merged this commit into the 4.13 branch :) Looks like you need take no action at all :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
Move the code which flattens an array to an external package. That's it for this simple change.