Skip to content

Commit 1b4392f

Browse files
authored
Merge pull request #6 from tsoenen/develop
hound fixes
2 parents 1c16860 + 9df685d commit 1b4392f

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

easybuild/tools/module_naming_scheme/generation_mns.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@
4141

4242
GMNS_ENV = "GENERATION_MODULE_NAMING_SCHEME_LOOKUP_TABLE"
4343

44+
4445
class GenerationModuleNamingScheme(ModuleNamingScheme):
4546
"""Class implementing the generational module naming scheme."""
4647

@@ -71,14 +72,14 @@ def __init__(self):
7172
print_result=False)
7273
self.generations = [x.split('-')[1].split('.')[0] for x in foss_filenames]
7374

74-
# get_toolchain_hierarchy() depends on ActiveMNS(), which can't point to
75+
# get_toolchain_hierarchy() depends on ActiveMNS(), which can't point to
7576
# GenerationModuleNamingScheme to prevent circular reference errors. For that purpose, the MNS
7677
# that ActiveMNS() points to is tweaked while get_toolchain_hierarchy() is used.
7778
ConfigurationVariables()._FrozenDict__dict['module_naming_scheme'] = 'EasyBuildMNS'
7879

7980
# map generations on toolchains
8081
for generation in self.generations:
81-
for tc in get_toolchain_hierarchy({'name':'foss', 'version':generation}):
82+
for tc in get_toolchain_hierarchy({'name': 'foss', 'version': generation}):
8283
self.lookup_table[(tc['name'], tc['version'])] = generation
8384
# include (foss, <generation>) as a toolchain aswell
8485
self.lookup_table[('foss', generation)] = generation

test/framework/module_generator.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1493,7 +1493,7 @@ def test_ec(ecfile, short_modname, mod_subdir, modpath_exts, user_modpath_exts,
14931493
# test error for examples without toolchain-generation mapping in lookup table. EasyConfig() calls
14941494
# det_module_subdir() of the generationModuleNamingScheme object for the toolchain (binutils)
14951495
with self.assertRaises(EasyBuildError) as cm:
1496-
ec = EasyConfig(glob.glob(os.path.join(ecs_dir, '*', '*', 'hwloc-1.6.2-GCC-4.9.3-2.26.eb'))[0])
1496+
EasyConfig(glob.glob(os.path.join(ecs_dir, '*', '*', 'hwloc-1.6.2-GCC-4.9.3-2.26.eb'))[0])
14971497

14981498
msg = "Couldn't map software version (binutils, 2.26) to a generation. Provide a customtoolchain " \
14991499
"mapping through GENERATION_MODULE_NAMING_SCHEME_LOOKUP_TABLE"

0 commit comments

Comments
 (0)