ci: add minimum GitHub token permissions for workflow #9177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ashish Kurmi <[email protected]>
ashishkurmi
changed the title
|
@Atry has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Hi @boahc077, could you trigger a CI run on your fork, checking if the GitHub Action is able to create a PR? |
Atry
reviewed
Sep 8, 2022
Comment on lines
+4
to
+6
| permissions: | ||
| contents: read | ||
|
|
There was a problem hiding this comment.
Do we need this permission given that contents: write permission has been assigned to the only job of this workflow?
There was a problem hiding this comment.
Yes, the contents: read is not strictly needed here. Setting that at the workflow level helps if a new job is added to the workflow. In that case, the new job will have contents: read, which is a secure-by-default setting.
Atry
suggested changes
Sep 9, 2022
|
@Atry It seems to be working fine: https://github.com/boahc077/hhvm/actions |
Atry
approved these changes
Sep 14, 2022
|
Thank you! @boahc077 |
87 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds minimum token permissions for the GITHUB_TOKEN in GitHub Actions workflows using https://github.com/step-security/secure-workflows.
The GitHub Actions workflow has a GITHUB_TOKEN with write access to multiple scopes.
Here is an example of the permissions in one of the workflow runs:
https://github.com/facebook/hhvm/runs/8220542290?check_suite_focus=true#step:1:19
After this change, the scopes will be reduced to the minimum needed for the following workflow:
The following workflow file already has the least privileged token permission set:
Motivation and Context
https://docs.github.com/en/actions/security-guides/automatic-token-authentication#modifying-the-permissions-for-the-github_token
Signed-off-by: Ashish Kurmi [email protected]