Skip to content

Commit 28c1c88

Browse files
alin23facebook-github-bot
authored andcommitted
Adjust row height by font size in PickerIOS
Summary: - [x] Explain the **motivation** for making this change. - [x] Provide a **test plan** demonstrating that the code is solid. - [x] Match the **code formatting** of the rest of the codebase. - [x] Target the `master` branch, NOT a "stable" branch. There is a problem where setting a bigger fontSize in PickerItem style clips the top and bottom of the text. This solves that problem by computing the row height using the font size. Create a PickerIOS component and set a larger font size (e.g. 50). The row height will grow accordingly. Example with `fontSize=50`: [Screenshot](http://i.imgur.com/YwK5fOc.png) Closes #13513 Differential Revision: D5692124 Pulled By: shergin fbshipit-source-id: 4629403e37ad68cdbc0b17b48ba924a77e133078
1 parent 22d283b commit 28c1c88

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

React/Views/RCTPicker.m

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,10 @@ - (NSString *)pickerView:(__unused UIPickerView *)pickerView
7070
return [RCTConvert NSString:_items[row][@"label"]];
7171
}
7272

73+
- (CGFloat)pickerView:(UIPickerView *)pickerView rowHeightForComponent:(NSInteger)component {
74+
return _font.pointSize + 19;
75+
}
76+
7377
- (UIView *)pickerView:(UIPickerView *)pickerView
7478
viewForRow:(NSInteger)row
7579
forComponent:(NSInteger)component

0 commit comments

Comments
 (0)