Re-enable direct debugging with JSC on iOS 16.4+ (#37914)

huntie · facebook-github-bot · commit 8b1bf058c4bc · 2023-06-15T12:27:32.000-07:00
Summary: Pull Request resolved: #37914 Restores #37874 (reverted earlier today), with fix for `JSCRuntime.cpp` build on Android. Changelog: None Reviewed By: cortinico Differential Revision: D46762984 fbshipit-source-id: 6d56f81b9d0c928887860993b2b729ed96c0734c
diff --git a/packages/react-native/ReactCommon/jsc/JSCRuntime.cpp b/packages/react-native/ReactCommon/jsc/JSCRuntime.cpp
@@ -398,6 +398,13 @@ JSCRuntime::JSCRuntime(JSGlobalContextRef ctx)
       stringCounter_(0)
 #endif
 {
+#ifndef NDEBUG
+#ifdef TARGET_OS_MAC
+  if (__builtin_available(macOS 13.3, iOS 16.4, tvOS 16.4, *)) {
+    JSGlobalContextSetInspectable(ctx_, true);
+  }
+#endif
+#endif
 }
 
 JSCRuntime::~JSCRuntime() {

Original file line number	Diff line number	Diff line change
`@@ -398,6 +398,13 @@ JSCRuntime::JSCRuntime(JSGlobalContextRef ctx)`
`398`	`398`	`stringCounter_(0)`
`399`	`399`	`#endif`
`400`	`400`	`{`
	`401`	`+#ifndef NDEBUG`
	`402`	`+#ifdef TARGET_OS_MAC`
	`403`	`+ if (__builtin_available(macOS 13.3, iOS 16.4, tvOS 16.4, *)) {`
	`404`	`+ JSGlobalContextSetInspectable(ctx_, true);`
	`405`	`+ }`
	`406`	`+#endif`
	`407`	`+#endif`
`401`	`408`	`}`
`402`	`409`
`403`	`410`	`JSCRuntime::~JSCRuntime() {`