From d5a6247226d288640e8ea7c7a18799c62f08daa4 Mon Sep 17 00:00:00 2001 From: Evan Bacon Date: Thu, 4 Nov 2021 22:15:34 -0700 Subject: [PATCH] feat: add more context to invalid text strings --- Libraries/Renderer/implementations/ReactFabric-dev.fb.js | 2 +- Libraries/Renderer/implementations/ReactFabric-dev.js | 2 +- Libraries/Renderer/implementations/ReactFabric-prod.js | 2 +- Libraries/Renderer/implementations/ReactFabric-profiling.js | 2 +- .../Renderer/implementations/ReactNativeRenderer-dev.fb.js | 2 +- Libraries/Renderer/implementations/ReactNativeRenderer-dev.js | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/Libraries/Renderer/implementations/ReactFabric-dev.fb.js b/Libraries/Renderer/implementations/ReactFabric-dev.fb.js index 6bc84b6f4956f5..4774768fd4231c 100644 --- a/Libraries/Renderer/implementations/ReactFabric-dev.fb.js +++ b/Libraries/Renderer/implementations/ReactFabric-dev.fb.js @@ -5110,7 +5110,7 @@ function createTextInstance( ) { { if (!hostContext.isInAParentText) { - error("Text strings must be rendered within a component."); + error(`Text string "${text}" must be rendered within a component.`); } } diff --git a/Libraries/Renderer/implementations/ReactFabric-dev.js b/Libraries/Renderer/implementations/ReactFabric-dev.js index c668e0af34777e..3dfa627e3b0f31 100644 --- a/Libraries/Renderer/implementations/ReactFabric-dev.js +++ b/Libraries/Renderer/implementations/ReactFabric-dev.js @@ -4947,7 +4947,7 @@ function createTextInstance( internalInstanceHandle ) { if (!hostContext.isInAParentText) { - throw Error("Text strings must be rendered within a component."); + throw Error(`Text string "${text}" must be rendered within a component.`); } var tag = nextReactTag; diff --git a/Libraries/Renderer/implementations/ReactFabric-prod.js b/Libraries/Renderer/implementations/ReactFabric-prod.js index de7df01710c172..5327d69325f0da 100644 --- a/Libraries/Renderer/implementations/ReactFabric-prod.js +++ b/Libraries/Renderer/implementations/ReactFabric-prod.js @@ -1900,7 +1900,7 @@ function createTextInstance( internalInstanceHandle ) { if (!hostContext.isInAParentText) - throw Error("Text strings must be rendered within a component."); + throw Error(`Text string "${text}" must be rendered within a component.`); hostContext = nextReactTag; nextReactTag += 2; return { diff --git a/Libraries/Renderer/implementations/ReactFabric-profiling.js b/Libraries/Renderer/implementations/ReactFabric-profiling.js index 487e23a55b8a53..ecfd53b58148a8 100644 --- a/Libraries/Renderer/implementations/ReactFabric-profiling.js +++ b/Libraries/Renderer/implementations/ReactFabric-profiling.js @@ -1948,7 +1948,7 @@ function createTextInstance( internalInstanceHandle ) { if (!hostContext.isInAParentText) - throw Error("Text strings must be rendered within a component."); + throw Error(`Text string "${text}" must be rendered within a component.`); hostContext = nextReactTag; nextReactTag += 2; return { diff --git a/Libraries/Renderer/implementations/ReactNativeRenderer-dev.fb.js b/Libraries/Renderer/implementations/ReactNativeRenderer-dev.fb.js index 1c526c7f8cbad6..66f99236ef7202 100644 --- a/Libraries/Renderer/implementations/ReactNativeRenderer-dev.fb.js +++ b/Libraries/Renderer/implementations/ReactNativeRenderer-dev.fb.js @@ -5258,7 +5258,7 @@ function createTextInstance( internalInstanceHandle ) { if (!hostContext.isInAParentText) { - throw new Error("Text strings must be rendered within a component."); + throw Error(`Text string "${text}" must be rendered within a component.`); } var tag = allocateTag(); diff --git a/Libraries/Renderer/implementations/ReactNativeRenderer-dev.js b/Libraries/Renderer/implementations/ReactNativeRenderer-dev.js index 557e1efd6dc47d..e33462c89f05e2 100644 --- a/Libraries/Renderer/implementations/ReactNativeRenderer-dev.js +++ b/Libraries/Renderer/implementations/ReactNativeRenderer-dev.js @@ -5095,7 +5095,7 @@ function createTextInstance( internalInstanceHandle ) { if (!hostContext.isInAParentText) { - throw Error("Text strings must be rendered within a component."); + throw Error(`Text string "${text}" must be rendered within a component.`); } var tag = allocateTag();