fix(preprocessor): return object, not just code #33576
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
facebook-github-bot
added
the
Shared with Meta
robhogan
approved these changes
Apr 6, 2022
Contributor
|
@robhogan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
Author
|
sorry @robhogan, missed a spot |
Base commit: 9573d7b |
Contributor
|
@robhogan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Base commit: 9573d7b |
Contributor
|
@robhogan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Collaborator
|
This pull request was successfully merged by @SimenB in e89c93f. When will my fix make it into a release? | Upcoming Releases |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 17, 2022
Summary: Fixes #33751 Relates to #33576 Jest 28 removed support for returning a string in the process method of a transformer (https://jestjs.io/docs/upgrading-to-jest28#transformer). This PR changes assetFileTransformer to return an object instead of a string. ## Changelog [Internal] [Fixed] - Return object from assetFileTransformer Pull Request resolved: #33756 Test Plan: Tests pass with Jest 28 when this change is made. Reviewed By: cipolleschi Differential Revision: D37242038 Pulled By: cortinico fbshipit-source-id: d8a5054f5378183f644cd1458785084b26782193
kelset
pushed a commit
that referenced
this pull request
Jul 12, 2022
Summary: Fixes #33751 Relates to #33576 Jest 28 removed support for returning a string in the process method of a transformer (https://jestjs.io/docs/upgrading-to-jest28#transformer). This PR changes assetFileTransformer to return an object instead of a string. ## Changelog [Internal] [Fixed] - Return object from assetFileTransformer Pull Request resolved: #33756 Test Plan: Tests pass with Jest 28 when this change is made. Reviewed By: cipolleschi Differential Revision: D37242038 Pulled By: cortinico fbshipit-source-id: d8a5054f5378183f644cd1458785084b26782193
danilobuerger
pushed a commit
to feastr/react-native
that referenced
this pull request
Jul 25, 2022
Summary: Fixes facebook#33751 Relates to facebook#33576 Jest 28 removed support for returning a string in the process method of a transformer (https://jestjs.io/docs/upgrading-to-jest28#transformer). This PR changes assetFileTransformer to return an object instead of a string. ## Changelog [Internal] [Fixed] - Return object from assetFileTransformer Pull Request resolved: facebook#33756 Test Plan: Tests pass with Jest 28 when this change is made. Reviewed By: cipolleschi Differential Revision: D37242038 Pulled By: cortinico fbshipit-source-id: d8a5054f5378183f644cd1458785084b26782193
danilobuerger
pushed a commit
to feastr/react-native
that referenced
this pull request
Aug 10, 2022
Summary: Fixes facebook#33751 Relates to facebook#33576 Jest 28 removed support for returning a string in the process method of a transformer (https://jestjs.io/docs/upgrading-to-jest28#transformer). This PR changes assetFileTransformer to return an object instead of a string. ## Changelog [Internal] [Fixed] - Return object from assetFileTransformer Pull Request resolved: facebook#33756 Test Plan: Tests pass with Jest 28 when this change is made. Reviewed By: cipolleschi Differential Revision: D37242038 Pulled By: cortinico fbshipit-source-id: d8a5054f5378183f644cd1458785084b26782193
danilobuerger
pushed a commit
to feastr/react-native
that referenced
this pull request
Nov 18, 2022
Summary: Fixes facebook#33751 Relates to facebook#33576 Jest 28 removed support for returning a string in the process method of a transformer (https://jestjs.io/docs/upgrading-to-jest28#transformer). This PR changes assetFileTransformer to return an object instead of a string. ## Changelog [Internal] [Fixed] - Return object from assetFileTransformer Pull Request resolved: facebook#33756 Test Plan: Tests pass with Jest 28 when this change is made. Reviewed By: cipolleschi Differential Revision: D37242038 Pulled By: cortinico fbshipit-source-id: d8a5054f5378183f644cd1458785084b26782193
Saadnajmi
pushed a commit
to Saadnajmi/react-native-macos
that referenced
this pull request
Jan 15, 2023
Summary:
Jest 28 will error if only a string is returned from a transfomer, it needs to be an object of `{code: string, map?: object}`. Returning an object has been supported since jestjs/jest#2290, released in Jest v20.
## Changelog
<!-- Help reviewers and the release process by writing your own changelog entry. For an example, see:
https://github.com/facebook/react-native/wiki/Changelog
-->
[Internal] [Fixed] - Return object from Jest preprocessor
Pull Request resolved: facebook#33576
Test Plan: Green CI?
Reviewed By: motiz88
Differential Revision: D35426748
Pulled By: robhogan
fbshipit-source-id: 3edb79b62b2d34274be192061817d3fcd8a7ba17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Jest 28 will error if only a string is returned from a transfomer, it needs to be an object of
{code: string, map?: object}. Returning an object has been supported since jestjs/jest#2290, released in Jest v20.Changelog
[Internal] [Fixed] - Return object from Jest preprocessor
Test Plan
Green CI?