build: remove deprecated File.exists() method from Hermes podspec. #35853
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Base commit: e6d1ab9 |
cipolleschi
approved these changes
Jan 17, 2023
Contributor
cipolleschi
left a comment
cipolleschi
left a comment
There was a problem hiding this comment.
Thanks for spotting this!
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@cipolleschi merged this pull request in 732a02a. |
kelset
added a commit
that referenced
this pull request
Jan 19, 2023
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
…acebook#35853) Summary: Remove deprecated `File.exists` method which was removed in later Ruby versions. Spotted during a brew upgrade [here](software-mansion/react-native-reanimated#3919). https://rubyapi.org/2.5/o/file#method-c-exist-3F ``` Fetching podspec for `hermes-engine` from `../node_modules/react-native/sdks/hermes-engine/hermes-engine.podspec` [!] Failed to load 'hermes-engine' podspec: [!] Invalid `hermes-engine.podspec` file: undefined method `exists?' for File:Class. # from [..]/node_modules/react-native/sdks/hermes-engine/hermes-engine.podspec:46 ``` ## Changelog [IOS] [FIXED] - Migrated `File.exists` from Hermes podspec for non-deprecated `File.exist`. Pull Request resolved: facebook#35853 Test Plan: Valid CI via CircleCI. Reviewed By: dmytrorykun Differential Revision: D42543148 Pulled By: cipolleschi fbshipit-source-id: 5ed30d8cc3e4c91a6e86d51f7d44a125bf85f7e8
Merged
This was referenced Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove deprecated
File.existsmethod which was removed in later Ruby versions. Spotted during a brew upgrade here.https://rubyapi.org/2.5/o/file#method-c-exist-3F
Changelog
[IOS] [FIXED] - Migrated
File.existsfrom Hermes podspec for non-deprecatedFile.exist.Test Plan
Valid CI via CircleCI.