Skip to content

Conversation

@cipolleschi
Copy link
Contributor

@cipolleschi cipolleschi commented Oct 14, 2023

Summary:

CircleCI is red because verdaccio fails to publish normalize-colors.
For some old dependencies, normalize-colors has been published on the official npmjs with the version we needs.

In order to mitigate the RN red ci, we can consume them directly from NPMJS.
As a followup, we created a task to investigate it next week.

Changelog:

[Internal] - Skip publishing or normalize colors

Test Plan:

Tested locally, running verdaccio and simulating CI. It worked.
CircleCI is green

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Oct 14, 2023
@cipolleschi cipolleschi force-pushed the cipolleschi/fix-publishing-norm-colors branch 4 times, most recently from 5fbec22 to c2b6f2d Compare October 14, 2023 18:58
@cipolleschi cipolleschi changed the title [RN][CI]Fix publishing of normalize colors [RN][CI]Skip publishing of normalize-colors Oct 14, 2023
@cipolleschi cipolleschi marked this pull request as ready for review October 14, 2023 19:01
@cipolleschi cipolleschi force-pushed the cipolleschi/fix-publishing-norm-colors branch from c2b6f2d to c875cbd Compare October 14, 2023 19:08
@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 17,214,618 +8
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 20,587,389 +17
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: d282ebe
Branch: main

@github-actions
Copy link

github-actions bot commented Oct 14, 2023

Fails
🚫

scripts/template/initialize.js#L70 - scripts/template/initialize.js line 70 – Replace "@react-native/normalize-colors" with '@react-native/normalize-colors' (prettier/prettier)

Warnings
⚠️ One hour and a half have passed and the E2E jobs haven't finished yet.
⚠️

scripts/template/initialize.js#L70 - scripts/template/initialize.js line 70 – Strings must use singlequote. (quotes)

Generated by 🚫 dangerJS against c2b6f2d

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Oct 14, 2023
@facebook-github-bot
Copy link
Contributor

@cipolleschi merged this pull request in a2f1189.

@cortinico cortinico deleted the cipolleschi/fix-publishing-norm-colors branch June 10, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants