Skip to content

[Linking] add Universal Links support to Linking.getInitialURL(). Fixes #6099 #6147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

[Linking] add Universal Links support to Linking.getInitialURL(). Fixes #6099 #6147

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6b48495
add Universal Links support to Linking.getInitialURL()
daesan Feb 25, 2016
eef33ee
style fix - add Universal Link support to Linking.getInitialURL()
daesan Feb 25, 2016
647c901
isEqualToString -> isEqual - add Universal Link support to Linking.ge…
daesan Feb 25, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion Libraries/LinkingIOS/RCTLinkingManager.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,18 @@ - (void)setBridge:(RCTBridge *)bridge

- (NSDictionary<NSString *, id> *)constantsToExport
{
NSURL *initialURL = _bridge.launchOptions[UIApplicationLaunchOptionsURLKey];
NSURL *initialURL;

if (_bridge.launchOptions[UIApplicationLaunchOptionsURLKey]) {
initialURL = _bridge.launchOptions[UIApplicationLaunchOptionsURLKey];
} else if (_bridge.launchOptions[UIApplicationLaunchOptionsUserActivityDictionaryKey]) {
NSDictionary *userActivityDictionary = _bridge.launchOptions[UIApplicationLaunchOptionsUserActivityDictionaryKey];

if ([userActivityDictionary[UIApplicationLaunchOptionsUserActivityTypeKey] isEqual:NSUserActivityTypeBrowsingWeb]) {
initialURL = ((NSUserActivity *)userActivityDictionary[@"UIApplicationLaunchOptionsUserActivityKey"]).webpageURL;
Copy link
Member

@javache javache Feb 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use the key defined in UIKit for this instead of the string?

Copy link
Contributor Author

@daesan daesan Feb 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason, UIApplicationLaunchOptionsUserActivityKey is not documented in Apple API docs and constant UIApplicationLaunchOptionsUserActivityKey is not being exported. The following URL is Apple API doc for launchOptions keys.

https://developer.apple.com/library/ios/documentation/UIKit/Reference/UIApplicationDelegate_Protocol/index.html?hl=ar#//apple_ref/doc/constant_group/Launch_Options_Keys

Copy link
Member

@javache javache Feb 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh right, I was looking for a different key

}
}

return @{@"initialURL": RCTNullIfNil(initialURL.absoluteString)};
}

Expand Down