diff --git a/ReactAndroid/src/main/java/com/facebook/react/modules/core/Timing.java b/ReactAndroid/src/main/java/com/facebook/react/modules/core/Timing.java index e95bf245e007dc..2fc348e8d5c4b5 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/modules/core/Timing.java +++ b/ReactAndroid/src/main/java/com/facebook/react/modules/core/Timing.java @@ -22,7 +22,6 @@ import com.facebook.react.bridge.ReactMethod; import com.facebook.react.bridge.UiThreadUtil; import com.facebook.react.bridge.WritableArray; -import com.facebook.react.common.MapBuilder; import com.facebook.react.common.SystemClock; import com.facebook.react.devsupport.DevSupportManager; import com.facebook.react.uimanager.ReactChoreographer; @@ -105,7 +104,7 @@ public void doFrame(long frameTimeNanos) { timer.mTargetTime = frameTimeMillis + timer.mInterval; mTimers.add(timer); } else { - mTimerIdsToTimers.remove(timer.mCallbackID); + mTimerIdsToTimers.remove(timer.mExecutorToken); } } } @@ -386,7 +385,7 @@ public void deleteTimer(ExecutorToken executorToken, int timerId) { return; } // We may have already called/removed it - mTimerIdsToTimers.remove(timerId); + mTimerIdsToTimers.remove(executorToken); mTimers.remove(timer); } } diff --git a/ReactAndroid/src/main/java/com/facebook/react/views/art/ARTRenderableViewManager.java b/ReactAndroid/src/main/java/com/facebook/react/views/art/ARTRenderableViewManager.java index 44ba41ba63030d..5af6d179453a06 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/views/art/ARTRenderableViewManager.java +++ b/ReactAndroid/src/main/java/com/facebook/react/views/art/ARTRenderableViewManager.java @@ -52,11 +52,11 @@ public String getName() { @Override public ReactShadowNode createShadowNodeInstance() { - if (mClassName == CLASS_GROUP) { + if (CLASS_GROUP.equals(mClassName)) { return new ARTGroupShadowNode(); - } else if (mClassName == CLASS_SHAPE) { + } else if (CLASS_SHAPE.equals(mClassName)) { return new ARTShapeShadowNode(); - } else if (mClassName == CLASS_TEXT) { + } else if (CLASS_TEXT.equals(mClassName)) { return new ARTTextShadowNode(); } else { throw new IllegalStateException("Unexpected type " + mClassName); @@ -65,11 +65,11 @@ public ReactShadowNode createShadowNodeInstance() { @Override public Class getShadowNodeClass() { - if (mClassName == CLASS_GROUP) { + if (CLASS_GROUP.equals(mClassName)) { return ARTGroupShadowNode.class; - } else if (mClassName == CLASS_SHAPE) { + } else if (CLASS_SHAPE.equals(mClassName)) { return ARTShapeShadowNode.class; - } else if (mClassName == CLASS_TEXT) { + } else if (CLASS_TEXT.equals(mClassName)) { return ARTTextShadowNode.class; } else { throw new IllegalStateException("Unexpected type " + mClassName);