Skip to content

Commit 03ed343

Browse files
committed
Fix build config
ReactDebugCurrentFrame is shared state. checkPropTypes should be imported via the main React export, not imported directly.
1 parent 0320b8e commit 03ed343

File tree

5 files changed

+23
-20
lines changed

5 files changed

+23
-20
lines changed

gulpfile.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,9 @@ var rendererSharedState = {
130130
React: 'react/lib/React',
131131
// Shared state
132132
ReactCurrentOwner: 'react/lib/ReactCurrentOwner',
133+
checkPropTypes: 'react/lib/checkPropTypes',
133134
ReactComponentTreeHook: 'react/lib/ReactComponentTreeHook',
135+
ReactDebugCurrentFrame: 'react/lib/ReactDebugCurrentFrame',
134136
};
135137

136138
var moduleMapReactDOM = Object.assign(

src/isomorphic/React.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ var ReactVersion = require('ReactVersion');
2121

2222
var onlyChild = require('onlyChild');
2323
var warning = require('warning');
24+
var checkPropTypes = require('checkPropTypes');
2425

2526
var createElement = ReactElement.createElement;
2627
var createFactory = ReactElement.createFactory;
@@ -71,6 +72,8 @@ var React = {
7172
cloneElement: cloneElement,
7273
isValidElement: ReactElement.isValidElement,
7374

75+
checkPropTypes: checkPropTypes,
76+
7477
// Classic
7578

7679
PropTypes: ReactPropTypes,

src/isomorphic/classic/types/ReactPropTypes.js

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313

1414
var ReactElement = require('ReactElement');
1515
var ReactPropTypesSecret = require('ReactPropTypesSecret');
16-
var checkPropTypes = require('checkPropTypes');
1716

1817
var emptyFunction = require('emptyFunction');
1918
var getIteratorFn = require('getIteratorFn');
@@ -123,8 +122,6 @@ if (__DEV__) {
123122
};
124123
}
125124

126-
ReactPropTypes.checkPropTypes = checkPropTypes;
127-
128125

129126
/**
130127
* inlined Object.is polyfill to avoid requiring consumers ship their own

src/isomorphic/classic/types/__tests__/ReactPropTypes-test.js

Lines changed: 18 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -12,17 +12,19 @@
1212
'use strict';
1313

1414
var PropTypes;
15+
var checkPropTypes;
1516
var checkReactTypeSpec;
1617
var React;
18+
var ReactDOM;
1719
var ReactFragment;
18-
var ReactTestUtils;
1920

2021
var Component;
2122
var MyComponent;
2223

2324
function resetWarningCache() {
2425
jest.resetModules();
2526
checkReactTypeSpec = require('checkReactTypeSpec');
27+
checkPropTypes = require('checkPropTypes');
2628
}
2729

2830
function getPropTypeWarningMessage(propTypes, object, componentName) {
@@ -109,8 +111,8 @@ describe('ReactPropTypes', () => {
109111
beforeEach(() => {
110112
PropTypes = require('ReactPropTypes');
111113
React = require('React');
114+
ReactDOM = require('ReactDOM');
112115
ReactFragment = require('ReactFragment');
113-
ReactTestUtils = require('ReactTestUtils');
114116
resetWarningCache();
115117
});
116118

@@ -123,7 +125,7 @@ describe('ReactPropTypes', () => {
123125
},
124126
};
125127
const props = { foo: 'foo' };
126-
const returnValue = PropTypes.checkPropTypes(propTypes, props, 'prop', 'testComponent', null);
128+
const returnValue = checkPropTypes(propTypes, props, 'prop', 'testComponent', null);
127129
expect(console.error.calls.argsFor(0)[0]).toContain('some error');
128130
expect(returnValue).toBe(undefined);
129131
});
@@ -136,7 +138,7 @@ describe('ReactPropTypes', () => {
136138
},
137139
};
138140
const props = { foo: 'foo' };
139-
const returnValue = PropTypes.checkPropTypes(propTypes, props, 'prop', 'testComponent', null);
141+
const returnValue = checkPropTypes(propTypes, props, 'prop', 'testComponent', null);
140142
expect(console.error.calls.argsFor(0)[0]).toContain('some error');
141143
expect(returnValue).toBe(undefined);
142144
});
@@ -436,17 +438,17 @@ describe('ReactPropTypes', () => {
436438
it('should be able to define a single child as label', () => {
437439
spyOn(console, 'error');
438440

439-
var instance = <Component label={<div />} />;
440-
ReactTestUtils.renderIntoDocument(instance);
441+
var container = document.createElement('div');
442+
ReactDOM.render(<Component label={<div />} />, container);
441443

442444
expectDev(console.error.calls.count()).toBe(0);
443445
});
444446

445447
it('should warn when passing no label and isRequired is set', () => {
446448
spyOn(console, 'error');
447449

448-
var instance = <Component />;
449-
ReactTestUtils.renderIntoDocument(instance);
450+
var container = document.createElement('div');
451+
ReactDOM.render(<Component />, container);
450452

451453
expectDev(console.error.calls.count()).toBe(1);
452454
});
@@ -1064,8 +1066,8 @@ describe('ReactPropTypes', () => {
10641066
}
10651067
};
10661068

1067-
var instance = <Component num={5} />;
1068-
ReactTestUtils.renderIntoDocument(instance);
1069+
var container = document.createElement('div');
1070+
ReactDOM.render(<Component num={5} />, container);
10691071

10701072
expect(spy.calls.count()).toBe(1);
10711073
expect(spy.calls.argsFor(0)[1]).toBe('num');
@@ -1081,8 +1083,8 @@ describe('ReactPropTypes', () => {
10811083
}
10821084
};
10831085

1084-
var instance = <Component bla={5} />;
1085-
ReactTestUtils.renderIntoDocument(instance);
1086+
var container = document.createElement('div');
1087+
ReactDOM.render(<Component bla={5} />, container);
10861088

10871089
expect(spy.calls.count()).toBe(1);
10881090
expect(spy.calls.argsFor(0)[1]).toBe('num');
@@ -1105,8 +1107,8 @@ describe('ReactPropTypes', () => {
11051107
}
11061108
};
11071109

1108-
var instance = <Component num={6} />;
1109-
ReactTestUtils.renderIntoDocument(instance);
1110+
var container = document.createElement('div');
1111+
ReactDOM.render(<Component num={6} />, container);
11101112
expectDev(console.error.calls.count()).toBe(1);
11111113
expect(
11121114
console.error.calls.argsFor(0)[0].replace(/\(at .+?:\d+\)/g, '(at **)')
@@ -1132,8 +1134,8 @@ describe('ReactPropTypes', () => {
11321134
}
11331135
};
11341136

1135-
var instance = <Component num={5} />;
1136-
ReactTestUtils.renderIntoDocument(instance);
1137+
var container = document.createElement('div');
1138+
ReactDOM.render(<Component num={5} />, container);
11371139
expectDev(console.error.calls.count()).toBe(0);
11381140
}
11391141
);

src/shared/types/checkReactTypeSpec.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
'use strict';
1313

1414
var checkPropTypes = require('checkPropTypes');
15-
1615
var { getStackAddendum } = require('ReactDebugCurrentFrame');
1716

1817
function checkReactTypeSpec(

0 commit comments

Comments
 (0)