Skip to content

Commit 0936484

Browse files
committed
Loosen assertion so it matches any production error
The exact error code isn't important.
1 parent 6545012 commit 0936484

File tree

3 files changed

+2
-9
lines changed

3 files changed

+2
-9
lines changed

scripts/fiber/tests-failing.txt

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,6 @@
11
src/isomorphic/classic/__tests__/ReactContextValidator-test.js
22
* should pass previous context to lifecycles
33

4-
src/renderers/dom/__tests__/ReactDOMProduction-test.js
5-
* should throw with an error code in production
6-
74
src/renderers/dom/shared/__tests__/ReactDOMComponent-test.js
85
* should clean up input value tracking
96
* should clean up input textarea tracking

scripts/fiber/tests-passing.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -523,6 +523,7 @@ src/renderers/dom/__tests__/ReactDOMProduction-test.js
523523
* should use prod React
524524
* should handle a simple flow
525525
* should call lifecycle methods
526+
* should throw with an error code in production
526527
* should keep track of namespace across portals in production
527528

528529
src/renderers/dom/fiber/__tests__/ReactDOMFiber-test.js

src/renderers/dom/__tests__/ReactDOMProduction-test.js

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -185,12 +185,7 @@ describe('ReactDOMProduction', () => {
185185

186186
var container = document.createElement('div');
187187
ReactDOM.render(<Component />, container);
188-
}).toThrowError(
189-
'Minified React error #109; visit ' +
190-
'http://facebook.github.io/react/docs/error-decoder.html?invariant=109&args[]=Component' +
191-
' for the full message or use the non-minified dev environment' +
192-
' for full errors and additional helpful warnings.'
193-
);
188+
}).toThrowError('Minified React error #');
194189
});
195190

196191
if (ReactDOMFeatureFlags.useFiber) {

0 commit comments

Comments
 (0)