Add comment and make the condition more obvious

sammy-SC · sammy-SC · commit 30f1466687b7 · 2022-11-01T15:01:55.000Z
diff --git a/packages/react-reconciler/src/ReactFiberCommitWork.new.js b/packages/react-reconciler/src/ReactFiberCommitWork.new.js
@@ -2880,7 +2880,8 @@ function commitMutationEffectsOnFiber(
         }
 
         if (isHidden) {
-          if (current !== null && current.memoizedState === null) {
+          // Check if this is an update, and the tree was previously visible.
+          if (current !== null && !wasHidden) {
             if ((offscreenBoundary.mode & ConcurrentMode) !== NoMode) {
               // Disappear the layout effects of all the children
               recursivelyTraverseDisappearLayoutEffects(offscreenBoundary);
diff --git a/packages/react-reconciler/src/ReactFiberCommitWork.old.js b/packages/react-reconciler/src/ReactFiberCommitWork.old.js
@@ -2880,7 +2880,8 @@ function commitMutationEffectsOnFiber(
         }
 
         if (isHidden) {
-          if (current !== null && current.memoizedState === null) {
+          // Check if this is an update, and the tree was previously visible.
+          if (current !== null && !wasHidden) {
             if ((offscreenBoundary.mode & ConcurrentMode) !== NoMode) {
               // Disappear the layout effects of all the children
               recursivelyTraverseDisappearLayoutEffects(offscreenBoundary);

Original file line number	Diff line number	Diff line change
`@@ -2880,7 +2880,8 @@ function commitMutationEffectsOnFiber(`
`2880`	`2880`	`}`
`2881`	`2881`
`2882`	`2882`	`if (isHidden) {`
`2883`		`- if (current !== null && current.memoizedState === null) {`
	`2883`	`+ // Check if this is an update, and the tree was previously visible.`
	`2884`	`+ if (current !== null && !wasHidden) {`
`2884`	`2885`	`if ((offscreenBoundary.mode & ConcurrentMode) !== NoMode) {`
`2885`	`2886`	`// Disappear the layout effects of all the children`
`2886`	`2887`	`recursivelyTraverseDisappearLayoutEffects(offscreenBoundary);`