Skip to content

Commit 4670c15

Browse files
committed
Remove disableNativeComponentFrames
1 parent afea1d0 commit 4670c15

9 files changed

+2
-14
lines changed

packages/shared/ReactComponentStackFrame.js

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,7 @@
1010
import type {Source} from 'shared/ReactElementType';
1111
import type {LazyComponent} from 'react/src/ReactLazy';
1212

13-
import {
14-
enableComponentStackLocations,
15-
disableNativeComponentFrames,
16-
} from 'shared/ReactFeatureFlags';
13+
import {enableComponentStackLocations} from 'shared/ReactFeatureFlags';
1714

1815
import {
1916
REACT_SUSPENSE_TYPE,
@@ -68,7 +65,7 @@ export function describeNativeComponentFrame(
6865
construct: boolean,
6966
): string {
7067
// If something asked for a stack inside a fake render, it should get ignored.
71-
if (disableNativeComponentFrames || !fn || reentry) {
68+
if (!fn || reentry) {
7269
return '';
7370
}
7471

packages/shared/ReactFeatureFlags.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -231,8 +231,6 @@ export const enableDebugTracing = false;
231231
// Track which Fiber(s) schedule render work.
232232
export const enableUpdaterTracking = __PROFILE__;
233233

234-
// Only enabled in RN, related to enableComponentStackLocations
235-
export const disableNativeComponentFrames = false;
236234
export const enableServerContext = true;
237235

238236
// Internal only.

packages/shared/forks/ReactFeatureFlags.native-fb.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,6 @@ export const enableClientRenderFallbackOnTextMismatch = true;
5959
export const enableComponentStackLocations = false;
6060
export const enableLegacyFBSupport = false;
6161
export const enableFilterEmptyStringAttributesDOM = false;
62-
export const disableNativeComponentFrames = false;
6362
export const skipUnmountedBoundaries = false;
6463
export const enableGetInspectorDataForInstanceInProduction = true;
6564
export const deferRenderPhaseUpdateToNextBatch = false;

packages/shared/forks/ReactFeatureFlags.native-oss.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,6 @@ export const enableClientRenderFallbackOnTextMismatch = true;
4949
export const enableComponentStackLocations = false;
5050
export const enableLegacyFBSupport = false;
5151
export const enableFilterEmptyStringAttributesDOM = false;
52-
export const disableNativeComponentFrames = false;
5352
export const skipUnmountedBoundaries = false;
5453
export const enableGetInspectorDataForInstanceInProduction = false;
5554
export const deferRenderPhaseUpdateToNextBatch = false;

packages/shared/forks/ReactFeatureFlags.test-renderer.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,6 @@ export const enableClientRenderFallbackOnTextMismatch = true;
4949
export const enableComponentStackLocations = true;
5050
export const enableLegacyFBSupport = false;
5151
export const enableFilterEmptyStringAttributesDOM = false;
52-
export const disableNativeComponentFrames = false;
5352
export const skipUnmountedBoundaries = false;
5453
export const enableGetInspectorDataForInstanceInProduction = false;
5554
export const deferRenderPhaseUpdateToNextBatch = false;

packages/shared/forks/ReactFeatureFlags.test-renderer.native.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@ export const disableModulePatternComponents = false;
4040
export const enableComponentStackLocations = false;
4141
export const enableLegacyFBSupport = false;
4242
export const enableFilterEmptyStringAttributesDOM = false;
43-
export const disableNativeComponentFrames = false;
4443
export const skipUnmountedBoundaries = false;
4544
export const enableGetInspectorDataForInstanceInProduction = false;
4645
export const deferRenderPhaseUpdateToNextBatch = false;

packages/shared/forks/ReactFeatureFlags.test-renderer.www.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,6 @@ export const enableClientRenderFallbackOnTextMismatch = true;
4949
export const enableComponentStackLocations = true;
5050
export const enableLegacyFBSupport = false;
5151
export const enableFilterEmptyStringAttributesDOM = true;
52-
export const disableNativeComponentFrames = false;
5352
export const skipUnmountedBoundaries = false;
5453
export const enableGetInspectorDataForInstanceInProduction = false;
5554
export const deferRenderPhaseUpdateToNextBatch = false;

packages/shared/forks/ReactFeatureFlags.www-dynamic.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,5 @@ export const revertRemovalOfSiblingPrerendering = false;
6060
// to __VARIANT__.
6161
export const enableTrustedTypesIntegration = false;
6262
export const disableSchedulerTimeoutBasedOnReactExpirationTime = false;
63-
export const disableNativeComponentFrames = false;
6463
// You probably *don't* want to add more hardcoded ones.
6564
// Instead, try to add them above with the __VARIANT__ value.

packages/shared/forks/ReactFeatureFlags.www.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ export const {
2626
enableDebugTracing,
2727
skipUnmountedBoundaries,
2828
enableUseRefAccessWarning,
29-
disableNativeComponentFrames,
3029
disableSchedulerTimeoutInWorkLoop,
3130
enableLazyContextPropagation,
3231
enableUnifiedSyncLane,

0 commit comments

Comments
 (0)