[compiler] Type ref prop as a ref

ghstack-source-id: a0c061e
Pull Request resolved: #29834

Author: josephsavona

compiler/packages/babel-plugin-react-compiler/src/HIR/ObjectShape.ts

@@ -188,6 +188,7 @@ export type ObjectShape = {
  * the inferred types for [] and {}.
  */
 export type ShapeRegistry = Map<string, ObjectShape>;
+export const BuiltInPropsId = "BuiltInProps";
 export const BuiltInArrayId = "BuiltInArray";
 export const BuiltInFunctionId = "BuiltInFunction";
 export const BuiltInJsxId = "BuiltInJsx";
@@ -207,6 +208,11 @@ export const BuiltInDispatchId = "BuiltInDispatch";
 // ShapeRegistry with default definitions for built-ins.
 export const BUILTIN_SHAPES: ShapeRegistry = new Map();
 
+// If the `ref` prop exists, it has the ref type
+addObject(BUILTIN_SHAPES, BuiltInPropsId, [
+  ["ref", { kind: "Object", shapeId: BuiltInUseRefId }],
+]);
+
 /* Built-in array shape */
 addObject(BUILTIN_SHAPES, BuiltInArrayId, [
   [

compiler/packages/babel-plugin-react-compiler/src/HIR/PrintHIR.ts

@@ -61,6 +61,7 @@ export function printFunction(fn: HIRFunction): string {
         .join(", ") +
       ")";
   }
+  definition += ` type=${fn.fnType}`;
   if (definition.length !== 0) {
     output.push(definition);
   }

compiler/packages/babel-plugin-react-compiler/src/TypeInference/InferTypes.ts

@@ -23,6 +23,7 @@ import {
   BuiltInFunctionId,
   BuiltInJsxId,
   BuiltInObjectId,
+  BuiltInPropsId,
   BuiltInUseRefId,
 } from "../HIR/ObjectShape";
 import { eachInstructionLValue, eachInstructionOperand } from "../HIR/visitors";
@@ -101,7 +102,13 @@ function* generate(
   func: HIRFunction
 ): Generator<TypeEquation, void, undefined> {
   if (func.env.fnType === "Component") {
-    const [_, ref] = func.params;
+    const [props, ref] = func.params;
+    if (props && props.kind === "Identifier") {
+      yield equation(props.identifier.type, {
+        kind: "Object",
+        shapeId: BuiltInPropsId,
+      });
+    }
     if (ref && ref.kind === "Identifier") {
       yield equation(ref.identifier.type, {
         kind: "Object",

compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/error.invalid-read-ref-prop-in-render-destructure.expect.md

@@ -0,0 +1,25 @@
+
+## Input
+
+```javascript
+// @validateRefAccessDuringRender @compilationMode(infer)
+function Component({ ref }) {
+  const value = ref.current;
+  return <div>{value}</div>;
+}
+
+```
+
+
+## Error
+
+```
+  2 | function Component({ ref }) {
+  3 |   const value = ref.current;
+> 4 |   return <div>{value}</div>;
+    |                ^^^^^ InvalidReact: Ref values (the `current` property) may not be accessed during render. (https://react.dev/reference/react/useRef). Cannot access ref value at read $17:TObject<BuiltInRefValue> (4:4)
+  5 | }
+  6 |
+```
+          
+      

compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/error.invalid-read-ref-prop-in-render-destructure.js

@@ -0,0 +1,5 @@
+// @validateRefAccessDuringRender @compilationMode(infer)
+function Component({ ref }) {
+  const value = ref.current;
+  return <div>{value}</div>;
+}

compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/error.invalid-read-ref-prop-in-render-property-load.expect.md

@@ -0,0 +1,25 @@
+
+## Input
+
+```javascript
+// @validateRefAccessDuringRender @compilationMode(infer)
+function Component(props) {
+  const value = props.ref.current;
+  return <div>{value}</div>;
+}
+
+```
+
+
+## Error
+
+```
+  2 | function Component(props) {
+  3 |   const value = props.ref.current;
+> 4 |   return <div>{value}</div>;
+    |                ^^^^^ InvalidReact: Ref values (the `current` property) may not be accessed during render. (https://react.dev/reference/react/useRef). Cannot access ref value at read $15:TObject<BuiltInRefValue> (4:4)
+  5 | }
+  6 |
+```
+          
+      

compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/error.invalid-read-ref-prop-in-render-property-load.js

@@ -0,0 +1,5 @@
+// @validateRefAccessDuringRender @compilationMode(infer)
+function Component(props) {
+  const value = props.ref.current;
+  return <div>{value}</div>;
+}