Flow: well formed exports for smaller packages (#25361)

kassens · web-flow · commit 9143864ae1f6 · 2022-10-03T16:52:41.000-04:00
Enforces well formed exports for packages where the fixes are small.
diff --git a/packages/react-devtools-core/src/standalone.js b/packages/react-devtools-core/src/standalone.js
@@ -57,7 +57,7 @@ function hookNamesModuleLoaderFunction() {
   );
 }
 
-function setContentDOMNode(value: HTMLElement) {
+function setContentDOMNode(value: HTMLElement): typeof DevtoolsUI {
   node = value;
 
   // Save so we can restore the exact waiting message between sessions.
@@ -70,12 +70,14 @@ function setProjectRoots(value: Array<string>) {
   projectRoots = value;
 }
 
-function setStatusListener(value: StatusListener) {
+function setStatusListener(value: StatusListener): typeof DevtoolsUI {
   statusListener = value;
   return DevtoolsUI;
 }
 
-function setDisconnectedCallback(value: OnDisconnectedCallback) {
+function setDisconnectedCallback(
+  value: OnDisconnectedCallback,
+): typeof DevtoolsUI {
   disconnectedCallback = value;
   return DevtoolsUI;
 }
diff --git a/packages/react-is/src/ReactIs.js b/packages/react-is/src/ReactIs.js
@@ -26,7 +26,7 @@ import {
 } from 'shared/ReactSymbols';
 import isValidElementType from 'shared/isValidElementType';
 
-export function typeOf(object: any) {
+export function typeOf(object: any): mixed {
   if (typeof object === 'object' && object !== null) {
     const $$typeof = object.$$typeof;
     switch ($$typeof) {
diff --git a/packages/react-refresh/src/ReactFreshRuntime.js b/packages/react-refresh/src/ReactFreshRuntime.js
@@ -637,7 +637,12 @@ export function _getMountedRootCount(): number {
 //   'useState{[foo, setFoo]}(0)',
 //   () => [useCustomHook], /* Lazy to avoid triggering inline requires */
 // );
-export function createSignatureFunctionForTransform() {
+export function createSignatureFunctionForTransform(): <T>(
+  type: T,
+  key: string,
+  forceReset?: boolean,
+  getCustomHooks?: () => Array<Function>,
+) => T | void {
   if (__DEV__) {
     let savedType;
     let hasCustomHooks;
diff --git a/packages/react-server/src/ReactFlightHooks.js b/packages/react-server/src/ReactFlightHooks.js
@@ -122,12 +122,14 @@ function unsupportedRefresh(): void {
 
 let currentCache: Map<Function, mixed> | null = null;
 
-export function setCurrentCache(cache: Map<Function, mixed> | null) {
+export function setCurrentCache(
+  cache: Map<Function, mixed> | null,
+): Map<Function, mixed> | null {
   currentCache = cache;
   return currentCache;
 }
 
-export function getCurrentCache() {
+export function getCurrentCache(): Map<Function, mixed> | null {
   return currentCache;
 }
 
diff --git a/packages/use-sync-external-store/src/useSyncExternalStoreShim.js b/packages/use-sync-external-store/src/useSyncExternalStoreShim.js
@@ -14,5 +14,8 @@ import {useSyncExternalStore as builtInAPI} from 'react';
 
 const shim = isServerEnvironment ? server : client;
 
-export const useSyncExternalStore =
-  builtInAPI !== undefined ? ((builtInAPI: any): typeof shim) : shim;
+export const useSyncExternalStore: <T>(
+  subscribe: (() => void) => () => void,
+  getSnapshot: () => T,
+  getServerSnapshot?: () => T,
+) => T = builtInAPI !== undefined ? builtInAPI : shim;
diff --git a/scripts/flow/config/flowconfig b/scripts/flow/config/flowconfig
@@ -48,43 +48,43 @@ munge_underscores=false
 types_first=false
 
 well_formed_exports=true
-; well_formed_exports.includes=<PROJECT_ROOT>/packages/dom-event-testing-library
-; well_formed_exports.includes=<PROJECT_ROOT>/packages/eslint-plugin-react-hooks
-; well_formed_exports.includes=<PROJECT_ROOT>/packages/jest-mock-scheduler
-; well_formed_exports.includes=<PROJECT_ROOT>/packages/jest-react
+well_formed_exports.includes=<PROJECT_ROOT>/packages/dom-event-testing-library
+well_formed_exports.includes=<PROJECT_ROOT>/packages/eslint-plugin-react-hooks
+well_formed_exports.includes=<PROJECT_ROOT>/packages/jest-mock-scheduler
+well_formed_exports.includes=<PROJECT_ROOT>/packages/jest-react
 ; well_formed_exports.includes=<PROJECT_ROOT>/packages/react
-; well_formed_exports.includes=<PROJECT_ROOT>/packages/react-art
-; well_formed_exports.includes=<PROJECT_ROOT>/packages/react-cache
-; well_formed_exports.includes=<PROJECT_ROOT>/packages/react-client
-; well_formed_exports.includes=<PROJECT_ROOT>/packages/react-debug-tools
-; well_formed_exports.includes=<PROJECT_ROOT>/packages/react-devtools
-; well_formed_exports.includes=<PROJECT_ROOT>/packages/react-devtools-core
-; well_formed_exports.includes=<PROJECT_ROOT>/packages/react-devtools-extensions
-; well_formed_exports.includes=<PROJECT_ROOT>/packages/react-devtools-inline
+well_formed_exports.includes=<PROJECT_ROOT>/packages/react-art
+well_formed_exports.includes=<PROJECT_ROOT>/packages/react-cache
+well_formed_exports.includes=<PROJECT_ROOT>/packages/react-client
+well_formed_exports.includes=<PROJECT_ROOT>/packages/react-debug-tools
+well_formed_exports.includes=<PROJECT_ROOT>/packages/react-devtools
+well_formed_exports.includes=<PROJECT_ROOT>/packages/react-devtools-core
+well_formed_exports.includes=<PROJECT_ROOT>/packages/react-devtools-extensions
+well_formed_exports.includes=<PROJECT_ROOT>/packages/react-devtools-inline
 well_formed_exports.includes=<PROJECT_ROOT>/packages/react-devtools-shared
 well_formed_exports.includes=<PROJECT_ROOT>/packages/react-devtools-shell
 well_formed_exports.includes=<PROJECT_ROOT>/packages/react-devtools-timeline
 ; well_formed_exports.includes=<PROJECT_ROOT>/packages/react-dom
 ; well_formed_exports.includes=<PROJECT_ROOT>/packages/react-dom-bindings
-; well_formed_exports.includes=<PROJECT_ROOT>/packages/react-fetch
-; well_formed_exports.includes=<PROJECT_ROOT>/packages/react-fs
-; well_formed_exports.includes=<PROJECT_ROOT>/packages/react-interactions
-; well_formed_exports.includes=<PROJECT_ROOT>/packages/react-is
+well_formed_exports.includes=<PROJECT_ROOT>/packages/react-fetch
+well_formed_exports.includes=<PROJECT_ROOT>/packages/react-fs
+well_formed_exports.includes=<PROJECT_ROOT>/packages/react-interactions
+well_formed_exports.includes=<PROJECT_ROOT>/packages/react-is
 ; well_formed_exports.includes=<PROJECT_ROOT>/packages/react-native-renderer
-; well_formed_exports.includes=<PROJECT_ROOT>/packages/react-noop-renderer
-; well_formed_exports.includes=<PROJECT_ROOT>/packages/react-pg
+well_formed_exports.includes=<PROJECT_ROOT>/packages/react-noop-renderer
+well_formed_exports.includes=<PROJECT_ROOT>/packages/react-pg
 well_formed_exports.includes=<PROJECT_ROOT>/packages/react-reconciler
-; well_formed_exports.includes=<PROJECT_ROOT>/packages/react-refresh
-; well_formed_exports.includes=<PROJECT_ROOT>/packages/react-server
-; well_formed_exports.includes=<PROJECT_ROOT>/packages/react-server-dom-relay
-; well_formed_exports.includes=<PROJECT_ROOT>/packages/react-server-dom-webpack
-; well_formed_exports.includes=<PROJECT_ROOT>/packages/react-server-native-relay
-; well_formed_exports.includes=<PROJECT_ROOT>/packages/react-suspense-test-utils
+well_formed_exports.includes=<PROJECT_ROOT>/packages/react-refresh
+well_formed_exports.includes=<PROJECT_ROOT>/packages/react-server
+well_formed_exports.includes=<PROJECT_ROOT>/packages/react-server-dom-relay
+well_formed_exports.includes=<PROJECT_ROOT>/packages/react-server-dom-webpack
+well_formed_exports.includes=<PROJECT_ROOT>/packages/react-server-native-relay
+well_formed_exports.includes=<PROJECT_ROOT>/packages/react-suspense-test-utils
 ; well_formed_exports.includes=<PROJECT_ROOT>/packages/react-test-renderer
 well_formed_exports.includes=<PROJECT_ROOT>/packages/scheduler
 ; well_formed_exports.includes=<PROJECT_ROOT>/packages/shared
-; well_formed_exports.includes=<PROJECT_ROOT>/packages/use-subscription
-; well_formed_exports.includes=<PROJECT_ROOT>/packages/use-sync-external-store
+well_formed_exports.includes=<PROJECT_ROOT>/packages/use-subscription
+well_formed_exports.includes=<PROJECT_ROOT>/packages/use-sync-external-store
 
 # Substituted by createFlowConfig.js:
 %REACT_RENDERER_FLOW_OPTIONS%

Original file line number	Diff line number	Diff line change
`@@ -57,7 +57,7 @@ function hookNamesModuleLoaderFunction() {`
`57`	`57`	`);`
`58`	`58`	`}`
`59`	`59`
`60`		`-function setContentDOMNode(value: HTMLElement) {`
	`60`	`+function setContentDOMNode(value: HTMLElement): typeof DevtoolsUI {`
`61`	`61`	`node = value;`
`62`	`62`
`63`	`63`	`// Save so we can restore the exact waiting message between sessions.`
`@@ -70,12 +70,14 @@ function setProjectRoots(value: Array<string>) {`
`70`	`70`	`projectRoots = value;`
`71`	`71`	`}`
`72`	`72`
`73`		`-function setStatusListener(value: StatusListener) {`
	`73`	`+function setStatusListener(value: StatusListener): typeof DevtoolsUI {`
`74`	`74`	`statusListener = value;`
`75`	`75`	`return DevtoolsUI;`
`76`	`76`	`}`
`77`	`77`
`78`		`-function setDisconnectedCallback(value: OnDisconnectedCallback) {`
	`78`	`+function setDisconnectedCallback(`
	`79`	`+ value: OnDisconnectedCallback,`
	`80`	`+): typeof DevtoolsUI {`
`79`	`81`	`disconnectedCallback = value;`
`80`	`82`	`return DevtoolsUI;`
`81`	`83`	`}`
Original file line number	Diff line number	Diff line change
`@@ -122,12 +122,14 @@ function unsupportedRefresh(): void {`
`122`	`122`
`123`	`123`	`let currentCache: Map<Function, mixed> \| null = null;`
`124`	`124`
`125`		`-export function setCurrentCache(cache: Map<Function, mixed> \| null) {`
	`125`	`+export function setCurrentCache(`
	`126`	`+ cache: Map<Function, mixed> \| null,`
	`127`	`+): Map<Function, mixed> \| null {`
`126`	`128`	`currentCache = cache;`
`127`	`129`	`return currentCache;`
`128`	`130`	`}`
`129`	`131`
`130`		`-export function getCurrentCache() {`
	`132`	`+export function getCurrentCache(): Map<Function, mixed> \| null {`
`131`	`133`	`return currentCache;`
`132`	`134`	`}`
`133`	`135`