Skip to content

Commit bc1a8e6

Browse files
committed
Add file-loader as dev dep to force yarn to hoist it
As this PR added the url-loader package to 2 other packages, Yarn hoisted it to the root node_modules folder. However, because file-loader was only a dependency of the scheduling profiler package, it was located in the scheduling profiler's node_modules folder. Thus, during the build process, url-loader could not find file-loader.
1 parent 41b7a3b commit bc1a8e6

File tree

4 files changed

+37
-6
lines changed

4 files changed

+37
-6
lines changed

packages/react-devtools-extensions/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@
3333
"chrome-launch": "^1.1.4",
3434
"crx": "^5.0.0",
3535
"css-loader": "^1.0.1",
36+
"file-loader": "^6.1.0",
3637
"firefox-profile": "^1.0.2",
3738
"node-libs-browser": "0.5.3",
3839
"nullthrows": "^1.0.0",

packages/react-devtools-inline/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@
3434
"babel-loader": "^8.0.4",
3535
"cross-env": "^3.1.4",
3636
"css-loader": "^1.0.1",
37+
"file-loader": "^6.1.0",
3738
"raw-loader": "^3.1.0",
3839
"style-loader": "^0.23.1",
3940
"url-loader": "^4.1.0",

packages/react-devtools-scheduling-profiler/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
"@reach/tooltip": "^0.11.2",
2323
"babel-loader": "^8.1.0",
2424
"css-loader": "^4.2.1",
25-
"file-loader": "^6.0.0",
25+
"file-loader": "^6.1.0",
2626
"html-webpack-plugin": "^4.3.0",
2727
"style-loader": "^1.2.1",
2828
"url-loader": "^4.1.0",

yarn.lock

Lines changed: 34 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2137,6 +2137,11 @@
21372137
resolved "https://registry.yarnpkg.com/@types/json-schema/-/json-schema-7.0.5.tgz#dcce4430e64b443ba8945f0290fb564ad5bac6dd"
21382138
integrity sha512-7+2BITlgjgDhH0vvwZU/HZJVyk+2XUlvxXe8dFMedNX/aMkaOq++rMAFXc0tM7ij15QaWlbdQASBR9dihi+bDQ==
21392139

2140+
"@types/json-schema@^7.0.5":
2141+
version "7.0.6"
2142+
resolved "https://registry.yarnpkg.com/@types/json-schema/-/json-schema-7.0.6.tgz#f4c7ec43e81b319a9815115031709f26987891f0"
2143+
integrity sha512-3c+yGKvVP5Y9TYBEibGNR+kLtijnj7mYrXRg+WpFb2X9xm04g/DXYkfg4hmzJQosc9snFNUPkbYIhu+KAm6jJw==
2144+
21402145
"@types/minimatch@*", "@types/minimatch@^3.0.3":
21412146
version "3.0.3"
21422147
resolved "https://registry.yarnpkg.com/@types/minimatch/-/minimatch-3.0.3.tgz#3dca0e3f33b200fc7d1139c0cd96c1268cadfd9d"
@@ -2753,6 +2758,11 @@ ajv-keywords@^3.1.0, ajv-keywords@^3.4.1:
27532758
resolved "https://registry.yarnpkg.com/ajv-keywords/-/ajv-keywords-3.4.1.tgz#ef916e271c64ac12171fd8384eaae6b2345854da"
27542759
integrity sha512-RO1ibKvd27e6FEShVFfPALuHI3WjSVNeK5FIsmme/LYRNxjKuNj+Dt7bucLa6NdSv3JcVTyMlm9kGR84z1XpaQ==
27552760

2761+
ajv-keywords@^3.5.2:
2762+
version "3.5.2"
2763+
resolved "https://registry.yarnpkg.com/ajv-keywords/-/ajv-keywords-3.5.2.tgz#31f29da5ab6e00d1c2d329acf7b5929614d5014d"
2764+
integrity sha512-5p6WTN0DdTGVQk6VjcEju19IgaHudalcfabD7yhDGeA6bcQnmL+CpveLJq/3hvfwd1aof6L386Ougkx6RfyMIQ==
2765+
27562766
27572767
version "4.1.0"
27582768
resolved "https://registry.yarnpkg.com/ajv-merge-patch/-/ajv-merge-patch-4.1.0.tgz#cd580e5860ac53431d6aa901fa3d5e2eb2b74a6c"
@@ -2781,6 +2791,16 @@ ajv@^6.10.0, ajv@^6.10.2, ajv@^6.12.2:
27812791
json-schema-traverse "^0.4.1"
27822792
uri-js "^4.2.2"
27832793

2794+
ajv@^6.12.4:
2795+
version "6.12.5"
2796+
resolved "https://registry.yarnpkg.com/ajv/-/ajv-6.12.5.tgz#19b0e8bae8f476e5ba666300387775fb1a00a4da"
2797+
integrity sha512-lRF8RORchjpKG50/WFf8xmg7sgCLFiYNNnqdKflk63whMQcWR5ngGjiSXkL9bjxy6B2npOK2HSMN49jEBMSkag==
2798+
dependencies:
2799+
fast-deep-equal "^3.1.1"
2800+
fast-json-stable-stringify "^2.0.0"
2801+
json-schema-traverse "^0.4.1"
2802+
uri-js "^4.2.2"
2803+
27842804
ajv@^6.5.5, ajv@^6.9.1:
27852805
version "6.10.2"
27862806
resolved "https://registry.yarnpkg.com/ajv/-/ajv-6.10.2.tgz#d3cea04d6b017b2894ad69040fec8b623eb4bd52"
@@ -6387,13 +6407,13 @@ file-entry-cache@^5.0.1:
63876407
dependencies:
63886408
flat-cache "^2.0.1"
63896409

6390-
file-loader@^6.0.0:
6391-
version "6.0.0"
6392-
resolved "https://registry.yarnpkg.com/file-loader/-/file-loader-6.0.0.tgz#97bbfaab7a2460c07bcbd72d3a6922407f67649f"
6393-
integrity sha512-/aMOAYEFXDdjG0wytpTL5YQLfZnnTmLNjn+AIrJ/6HVnTfDqLsVKUUwkDf4I4kgex36BvjuXEn/TX9B/1ESyqQ==
6410+
file-loader@^6.1.0:
6411+
version "6.1.0"
6412+
resolved "https://registry.yarnpkg.com/file-loader/-/file-loader-6.1.0.tgz#65b9fcfb0ea7f65a234a1f10cdd7f1ab9a33f253"
6413+
integrity sha512-26qPdHyTsArQ6gU4P1HJbAbnFTyT2r0pG7czh1GFAd9TZbj0n94wWbupgixZH/ET/meqi2/5+F7DhW4OAXD+Lg==
63946414
dependencies:
63956415
loader-utils "^2.0.0"
6396-
schema-utils "^2.6.5"
6416+
schema-utils "^2.7.1"
63976417

63986418
63996419
version "1.0.0"
@@ -12182,6 +12202,15 @@ schema-utils@^2.6.5, schema-utils@^2.6.6, schema-utils@^2.7.0:
1218212202
ajv "^6.12.2"
1218312203
ajv-keywords "^3.4.1"
1218412204

12205+
schema-utils@^2.7.1:
12206+
version "2.7.1"
12207+
resolved "https://registry.yarnpkg.com/schema-utils/-/schema-utils-2.7.1.tgz#1ca4f32d1b24c590c203b8e7a50bf0ea4cd394d7"
12208+
integrity sha512-SHiNtMOUGWBQJwzISiVYKu82GiV4QYGePp3odlY1tuKO7gPtphAT5R/py0fA6xtbgLL/RvtJZnU9b8s0F1q0Xg==
12209+
dependencies:
12210+
"@types/json-schema" "^7.0.5"
12211+
ajv "^6.12.4"
12212+
ajv-keywords "^3.5.2"
12213+
1218512214
select-hose@^2.0.0:
1218612215
version "2.0.0"
1218712216
resolved "https://registry.yarnpkg.com/select-hose/-/select-hose-2.0.0.tgz#625d8658f865af43ec962bfc376a37359a4994ca"

0 commit comments

Comments
 (0)