Tightened up Flow types, disabled ReactNativeFiber (for now), added/cleaned up some comments

Author: Brian Vaughn

flow/react-native-host-hooks.js

@@ -33,7 +33,7 @@ declare module 'UIManager' {
     reactTag : number,
     viewName : string,
     rootTag : number,
-    props : Object,
+    props : ?Object,
   ) : void;
   declare function manageChildren(
     containerTag : number,
@@ -56,7 +56,7 @@ declare module 'UIManager' {
   declare function updateView(
     reactTag : number,
     viewName : string,
-    props : Object,
+    props : ?Object,
   ) : void;
 }
 declare module 'View' {

src/renderers/native/NativeMethodsMixin.js

@@ -152,7 +152,7 @@ var NativeMethodsMixin = {
     UIManager.updateView(
       (findNodeHandle(this) : any),
       this.viewConfig.uiViewClassName,
-      (updatePayload : any)
+      updatePayload,
     );
   },
 

src/renderers/native/ReactNative.js

@@ -11,8 +11,11 @@
  */
 'use strict';
 
+/** TODO (bvaughn) Enable Fiber experiement
 const ReactNativeFeatureFlags = require('ReactNativeFeatureFlags');
 
 module.exports = ReactNativeFeatureFlags.useFiber
   ? require('ReactNativeFiber')
   : require('ReactNativeStack');
+*/
+module.exports = require('ReactNativeStack');

src/renderers/native/ReactNativeBaseComponent.js

@@ -112,7 +112,7 @@ ReactNativeBaseComponent.Mixin = {
       UIManager.updateView(
         this._rootNodeID,
         this.viewConfig.uiViewClassName,
-        (updatePayload : any)
+        updatePayload
       );
     }
 

src/renderers/native/ReactNativeComponentTree.js

@@ -44,8 +44,7 @@ function precacheFiberNode(hostInst, tag) {
 }
 
 function uncacheNode(inst) {
-  // TODO (bvaughn) Clean up once Stack is deprecated
-  var tag = inst._rootNodeID || inst.stateNode._nativeTag;
+  var tag = inst._rootNodeID;
   if (tag) {
     delete instanceCache[tag];
   }

src/renderers/native/ReactNativeFiber.js

@@ -29,14 +29,18 @@ const UIManager = require('UIManager');
 
 const deepFreezeAndThrowOnMutationInDev = require('deepFreezeAndThrowOnMutationInDev');
 const findNodeHandle = require('findNodeHandle');
+const invariant = require('invariant');
 
 const { precacheFiberNode, uncacheFiberNode } = ReactNativeComponentTree;
 
 ReactNativeInjection.inject();
 
 type Container = number;
+type Instance = {
+  _children: Array<Instance | number>,
+  _nativeTag: number,
+};
 type Props = Object;
-type Instance = any;
 type TextInstance = number;
 
 function NativeHostComponent(tag) {
@@ -123,7 +127,7 @@ const NativeRenderer = ReactFiberReconciler({
     UIManager.updateView(
       (instance : any)._nativeTag, // reactTag
       viewConfig.uiViewClassName, // viewName
-      (updatePayload : any), // props
+      updatePayload, // props
     );
   },
 
@@ -154,7 +158,7 @@ const NativeRenderer = ReactFiberReconciler({
       tag, // reactTag
       viewConfig.uiViewClassName, // viewName
       rootContainerInstance, // rootTag
-      (updatePayload : any), // props
+      updatePayload, // props
     );
 
     const component = new NativeHostComponent(tag);
@@ -215,7 +219,17 @@ const NativeRenderer = ReactFiberReconciler({
     child : Instance | TextInstance,
     beforeChild : Instance | TextInstance
   ) : void {
+    // TODO (bvaughn): Remove this check when...
+    // We create a wrapper object for the container in ReactNative render()
+    // Or we refactor to remove wrapper objects entirely.
+    // For more info on pros/cons see PR #8560 description.
+    invariant(
+      !(typeof parentInstance === 'number'),
+      'Container does not support insertBefore operation',
+    );
+
     const children = (parentInstance : any)._children;
+
     const beforeChildIndex = children.indexOf(beforeChild);
     const index = children.indexOf(child);
 
@@ -247,7 +261,7 @@ const NativeRenderer = ReactFiberReconciler({
   },
 
   prepareForCommit() : void {
-    // Noop?
+    // Noop
   },
 
   prepareUpdate(
@@ -292,11 +306,11 @@ const NativeRenderer = ReactFiberReconciler({
   },
 
   resetAfterCommit() : void {
-    // Noop?
+    // Noop
   },
 
   resetTextContent(instance : Instance) : void {
-    // Noop?
+    // Noop
   },
 
   scheduleAnimationCallback: global.requestAnimationFrame,

src/renderers/native/ReactNativeStack.js

@@ -11,12 +11,9 @@
  */
 'use strict';
 
-// Require ReactNativeDefaultInjection first for its side effects of setting up
-// the JS environment
 var ReactNativeComponentTree = require('ReactNativeComponentTree');
 var ReactNativeInjection = require('ReactNativeInjection');
 var ReactNativeStackInjection = require('ReactNativeStackInjection');
-
 var ReactNativeMount = require('ReactNativeMount');
 var ReactUpdates = require('ReactUpdates');