Skip to content

Commit e200362

Browse files
committed
Provide icon to edge devtools. (#26543)
<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory. Before submitting a pull request, please make sure the following is done: 1. Fork [the repository](https://github.com/facebook/react) and create your branch from `main`. 2. Run `yarn` in the repository root. 3. If you've fixed a bug or added code that should be tested, add tests! 4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch TestName` is helpful in development. 5. Run `yarn test --prod` to test in the production environment. It supports the same options as `yarn test`. 6. If you need a debugger, run `yarn test --debug --watch TestName`, open `chrome://inspect`, and press "Inspect". 7. Format your code with [prettier](https://github.com/prettier/prettier) (`yarn prettier`). 8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only check changed files. 9. Run the [Flow](https://flowtype.org/) type checks (`yarn flow`). 10. If you haven't already, complete the CLA. Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html --> ## Summary Addresses #26352. This PR explicitly passes an icon to `chrome.devtools.panels.create()`, so that edge devtools will display the icon when in [Focus Mode](https://learn.microsoft.com/en-us/microsoft-edge/devtools-guide-chromium/experimental-features/focus-mode). <!-- Explain the **motivation** for making this change. What existing problem does the pull request solve? --> ## How did you test this change? Passing test suite (`yarn test` & `yarn test --prod`) ✅ Passing lint (`yarn linc`) ✅ Passing type checks (`yarn flow`) ✅ **Visual Testing** Before Changes | After Changes :-------------------------:|:-------------------------: ![](https://user-images.githubusercontent.com/15645169/229591145-fe99df06-e2e3-4f21-ae31-f770d584ca6c.png) | ![](https://user-images.githubusercontent.com/15645169/229591594-26c6cbaf-f345-4367-b234-8f3c8ab3ccb1.png) <!-- Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes the user interface. How exactly did you verify that your PR solves the issue you wanted to solve? If you leave this empty, your PR will very likely be closed. --> DiffTrain build for commit 5426af3.
1 parent 5f760fb commit e200362

File tree

13 files changed

+19
-19
lines changed

13 files changed

+19
-19
lines changed

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-dev.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23752,7 +23752,7 @@ function createFiberRoot(
2375223752
return root;
2375323753
}
2375423754

23755-
var ReactVersion = "18.3.0-next-f9de24a26-20230411";
23755+
var ReactVersion = "18.3.0-next-5426af3d5-20230411";
2375623756

2375723757
// Might add PROFILE later.
2375823758

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-prod.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8610,7 +8610,7 @@ var devToolsConfig$jscomp$inline_1021 = {
86108610
throw Error("TestRenderer does not support findFiberByHostInstance()");
86118611
},
86128612
bundleType: 0,
8613-
version: "18.3.0-next-f9de24a26-20230411",
8613+
version: "18.3.0-next-5426af3d5-20230411",
86148614
rendererPackageName: "react-test-renderer"
86158615
};
86168616
var internals$jscomp$inline_1204 = {
@@ -8641,7 +8641,7 @@ var internals$jscomp$inline_1204 = {
86418641
scheduleRoot: null,
86428642
setRefreshHandler: null,
86438643
getCurrentFiber: null,
8644-
reconcilerVersion: "18.3.0-next-f9de24a26-20230411"
8644+
reconcilerVersion: "18.3.0-next-5426af3d5-20230411"
86458645
};
86468646
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
86478647
var hook$jscomp$inline_1205 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-profiling.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9036,7 +9036,7 @@ var devToolsConfig$jscomp$inline_1063 = {
90369036
throw Error("TestRenderer does not support findFiberByHostInstance()");
90379037
},
90389038
bundleType: 0,
9039-
version: "18.3.0-next-f9de24a26-20230411",
9039+
version: "18.3.0-next-5426af3d5-20230411",
90409040
rendererPackageName: "react-test-renderer"
90419041
};
90429042
var internals$jscomp$inline_1245 = {
@@ -9067,7 +9067,7 @@ var internals$jscomp$inline_1245 = {
90679067
scheduleRoot: null,
90689068
setRefreshHandler: null,
90699069
getCurrentFiber: null,
9070-
reconcilerVersion: "18.3.0-next-f9de24a26-20230411"
9070+
reconcilerVersion: "18.3.0-next-5426af3d5-20230411"
90719071
};
90729072
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
90739073
var hook$jscomp$inline_1246 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-dev.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ if (
2727
}
2828
"use strict";
2929

30-
var ReactVersion = "18.3.0-next-f9de24a26-20230411";
30+
var ReactVersion = "18.3.0-next-5426af3d5-20230411";
3131

3232
// ATTENTION
3333
// When adding new symbols to this file,

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-prod.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -639,4 +639,4 @@ exports.useSyncExternalStore = function (
639639
);
640640
};
641641
exports.useTransition = useTransition;
642-
exports.version = "18.3.0-next-f9de24a26-20230411";
642+
exports.version = "18.3.0-next-5426af3d5-20230411";

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-profiling.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -642,7 +642,7 @@ exports.useSyncExternalStore = function (
642642
);
643643
};
644644
exports.useTransition = useTransition;
645-
exports.version = "18.3.0-next-f9de24a26-20230411";
645+
exports.version = "18.3.0-next-5426af3d5-20230411";
646646

647647
/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
648648
if (
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
f9de24a26af23ce63b6f0474670870c86e1a631c
1+
5426af3d50ff706f3ebeb4764f838e0a3812bf9a

compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-dev.fb.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27059,7 +27059,7 @@ function createFiberRoot(
2705927059
return root;
2706027060
}
2706127061

27062-
var ReactVersion = "18.3.0-next-f9de24a26-20230411";
27062+
var ReactVersion = "18.3.0-next-5426af3d5-20230411";
2706327063

2706427064
function createPortal$1(
2706527065
children,

compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-prod.fb.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9479,7 +9479,7 @@ var roots = new Map(),
94799479
devToolsConfig$jscomp$inline_1045 = {
94809480
findFiberByHostInstance: getInstanceFromNode,
94819481
bundleType: 0,
9482-
version: "18.3.0-next-f9de24a26-20230411",
9482+
version: "18.3.0-next-5426af3d5-20230411",
94839483
rendererPackageName: "react-native-renderer",
94849484
rendererConfig: {
94859485
getInspectorDataForViewTag: function () {
@@ -9521,7 +9521,7 @@ var internals$jscomp$inline_1274 = {
95219521
scheduleRoot: null,
95229522
setRefreshHandler: null,
95239523
getCurrentFiber: null,
9524-
reconcilerVersion: "18.3.0-next-f9de24a26-20230411"
9524+
reconcilerVersion: "18.3.0-next-5426af3d5-20230411"
95259525
};
95269526
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
95279527
var hook$jscomp$inline_1275 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-profiling.fb.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10188,7 +10188,7 @@ var roots = new Map(),
1018810188
devToolsConfig$jscomp$inline_1123 = {
1018910189
findFiberByHostInstance: getInstanceFromNode,
1019010190
bundleType: 0,
10191-
version: "18.3.0-next-f9de24a26-20230411",
10191+
version: "18.3.0-next-5426af3d5-20230411",
1019210192
rendererPackageName: "react-native-renderer",
1019310193
rendererConfig: {
1019410194
getInspectorDataForViewTag: function () {
@@ -10243,7 +10243,7 @@ var roots = new Map(),
1024310243
scheduleRoot: null,
1024410244
setRefreshHandler: null,
1024510245
getCurrentFiber: null,
10246-
reconcilerVersion: "18.3.0-next-f9de24a26-20230411"
10246+
reconcilerVersion: "18.3.0-next-5426af3d5-20230411"
1024710247
});
1024810248
exports.createPortal = function (children, containerTag) {
1024910249
return createPortal$1(

0 commit comments

Comments
 (0)