Deprecate ReactTestUtils.mockComponent() #13193
Conversation
Details of bundled changes.Comparing: afd4649...e3f3354 react-dom
Generated by 🚫 dangerJS |
| false, | ||
| 'ReactTestUtils.mockComponent() is deprecated. ' + | ||
| 'We recommend using shallow rendering or jest.mock() instead.', | ||
| ); |
There was a problem hiding this comment.
Minor, but other warnings use more direct language like:
"ReactTestUtils.mockComponent() is deprecated. Use shallow rendering or jest.mock() instead."`.
This isn't a hard recommendation, so I think softening it a bit makes sense, but it just crossed my mind.
There was a problem hiding this comment.
Cool, I'm happy with tweaking the wording 😄
| ReactTestUtils.mockComponent(MockedComponent), | ||
| ).toLowPriorityWarnDev( | ||
| 'ReactTestUtils.mockComponent() is deprecated. ' + | ||
| 'Use shallow rendering or jest.mock() instead.', |
There was a problem hiding this comment.
Let's add an fb.me link that either points to a gist or a warning page with a drop-in replacement code? People who rely on it might not understand what mockComponent was doing exactly.
| * @return {object} the ReactTestUtils object (for chaining) | ||
| */ | ||
| mockComponent: function(module, mockTagName) { | ||
| lowPriorityWarning( |
There was a problem hiding this comment.
This needs to be behind a duplicate check. Otherwise it might significantly spam console in tests.
There was a problem hiding this comment.
Follow up PR #13194
ghost
mentioned this pull request
5 participants
Resolves #11019. Replaces #13192.