Fix unwinding starting with a wrong Fiber on error in the complete phase #13237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This currently fails the tests due to an unexpected warning.
The bug was caused by a structure like this:
</Provider>
</div>
</errorInCompletePhase>
We forgot to update nextUnitOfWork so it was still pointing at Provider when errorInCompletePhase threw. As a result, we would try to unwind from Provider (rather than from errorInCompletePhase), and thus pop the Provider twice.
gaearon
changed the title
acdlite
reviewed
Jul 19, 2018
| workInProgress, | ||
| nextRenderExpirationTime, | ||
| ); | ||
| let next = nextUnitOfWork; |
There was a problem hiding this comment.
next is always null ever since we deleted call/return. Let's just remove the block below.
|
Oh I guess we don't because Flow :) Ok. |
acdlite
approved these changes
Jul 19, 2018
Merged
This was referenced Sep 7, 2018
ghost
mentioned this pull request
This was referenced Nov 1, 2018
ghost
mentioned this pull request
ghost
mentioned this pull request
This was referenced Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds two regression tests (one for profiler stack and one for context stack). Also fixes the bug.
The bug was caused by a structure like this:
We forgot to update
nextUnitOfWork(see the fix in the last commit). So it was still pointing atProviderwhenerrorInCompletePhasethrew. Normally we would update it right after so it wouldn't be noticeable, but in case of exception its value at the moment of throwing matters.As a result, we would try to unwind from
Provider(rather than fromerrorInCompletePhase), and thus pop theProvidertwice. It has already been popped at the beginning of the complete phase.This was easy to miss because a throwing complete phase is uncommon. But it can happen in host configs (e.g. RN nesting or DOM invalid style invariants).
I verified this fixes the original internal issue too.