Don't search beyond Sync roots for highest priority work #13335
Merged
+5
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebmarkbage
approved these changes
Aug 7, 2018
Collaborator
sebmarkbage
left a comment
sebmarkbage
left a comment
There was a problem hiding this comment.
I'm convinced we should fix the general issue though since even just always picking the first one is still inline with semantics and even better for a single root.
Collaborator
Author
|
By "fix the general issue" you mean "stop prioritizing across roots" or...? |
Collaborator
|
Why is this n^2 in the first place though? |
Collaborator
Author
|
We schedule N roots in a lifecycle.
|
Collaborator
Author
|
Regardless of how we can optimize it, it seems like the current search procedure is useless after encountering a Sync root so I'll get this in. |
Merged
This was referenced Sep 7, 2018
ghost
mentioned this pull request
This was referenced Nov 1, 2018
ghost
mentioned this pull request
ghost
mentioned this pull request
This was referenced Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13334 at a cost of one extra comparison per scheduled root.
Not directly observable — verified by manual testing with test cases from #13334 and #12700.
Unless I'm missing something it's useless to continue searching once we've found sync work since nothing else is going to win.