Allow rendering into document fragments. Fixes #840 #3169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @sebmarkbage |
Collaborator
|
Need to test updating etc. too. |
Collaborator
|
cf. #1167 |
Contributor
Author
|
@sebmarkbage Updated #3176 to include a test verifying updating. |
Collaborator
|
hm... This is a bit misleading for the Lets chat after my meeting. |
jimfb
added a commit
that referenced
this pull request
Mar 16, 2015
Allow rendering into document fragments. Fixes #840
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow rendering into document fragments. Fixes #840
Manually tested mounting and unmounting; that worked. Meaningful unit tests require the webcomponent polyfill, which is non-trivial to load into jsdom, so we'll figure out how to add more unit tests later.