Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion packages/react-client/src/ReactFlightClient.js
Original file line number Diff line number Diff line change
Expand Up @@ -649,7 +649,13 @@ export function reportGlobalError(response: Response, error: Error): void {
});
if (enableProfilerTimer && enableComponentPerformanceTrack) {
markAllTracksInOrder();
flushComponentPerformance(getChunk(response, 0), 0, -Infinity, -Infinity);
flushComponentPerformance(
response,
getChunk(response, 0),
0,
-Infinity,
-Infinity,
);
}
}

Expand Down Expand Up @@ -2748,6 +2754,7 @@ function resolveTypedArray(
}

function flushComponentPerformance(
response: Response,
root: SomeChunk<any>,
trackIdx: number, // Next available track
trackTime: number, // The time after which it is available,
Expand Down Expand Up @@ -2838,6 +2845,7 @@ function flushComponentPerformance(
let childTrackTime = trackTime;
for (let i = 0; i < children.length; i++) {
const childResult = flushComponentPerformance(
response,
children[i],
childTrackIdx,
childTrackTime,
Expand Down Expand Up @@ -2876,6 +2884,7 @@ function flushComponentPerformance(
startTime,
endTime,
childrenEndTime,
response._rootEnvironmentName,
);
// Track the root most component of the result for deduping logging.
result.component = componentInfo;
Expand Down
22 changes: 17 additions & 5 deletions packages/react-client/src/ReactFlightPerformanceTrack.js
Original file line number Diff line number Diff line change
Expand Up @@ -72,22 +72,33 @@ export function logComponentRender(
startTime: number,
endTime: number,
childrenEndTime: number,
rootEnv: string,
): void {
if (supportsUserTiming && childrenEndTime >= 0 && trackIdx < 10) {
const env = componentInfo.env;
const name = componentInfo.name;
const isPrimaryEnv = env === rootEnv;
const selfTime = endTime - startTime;
reusableComponentDevToolDetails.color =
selfTime < 0.5
? 'primary-light'
? isPrimaryEnv
? 'primary-light'
: 'secondary-light'
: selfTime < 50
? 'primary'
? isPrimaryEnv
? 'primary'
: 'secondary'
: selfTime < 500
? 'primary-dark'
? isPrimaryEnv
? 'primary-dark'
: 'secondary-dark'
: 'error';
reusableComponentDevToolDetails.track = trackNames[trackIdx];
reusableComponentOptions.start = startTime < 0 ? 0 : startTime;
reusableComponentOptions.end = childrenEndTime;
performance.measure(name, reusableComponentOptions);
const entryName =
isPrimaryEnv || env === undefined ? name : name + ' [' + env + ']';
performance.measure(entryName, reusableComponentOptions);
}
}

Expand All @@ -103,6 +114,7 @@ export function logDedupedComponentRender(
reusableComponentDevToolDetails.track = trackNames[trackIdx];
reusableComponentOptions.start = startTime < 0 ? 0 : startTime;
reusableComponentOptions.end = endTime;
performance.measure(name + ' [deduped]', reusableComponentOptions);
const entryName = name + ' [deduped]';
performance.measure(entryName, reusableComponentOptions);
}
}
Loading