From 44876577f4cf3d5ddff840328f0c0dcff736f821 Mon Sep 17 00:00:00 2001 From: Sebastian Sebbie Silbermann Date: Fri, 20 Jun 2025 09:38:52 +0200 Subject: [PATCH 1/3] Fix prelease workflows for `dry: false` --- .github/workflows/runtime_prereleases.yml | 6 +++--- .github/workflows/runtime_releases_from_npm_manual.yml | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/runtime_prereleases.yml b/.github/workflows/runtime_prereleases.yml index c3502b91fc9be..ee340e079f3d3 100644 --- a/.github/workflows/runtime_prereleases.yml +++ b/.github/workflows/runtime_prereleases.yml @@ -85,7 +85,7 @@ jobs: --skipTests \ --tags=${{ inputs.dist_tag }} \ --onlyPackages=${{ inputs.only_packages }} ${{ (inputs.dry && '') || '\'}} - ${{ inputs.dry && '--dry'}} + ${{ inputs.dry && '--dry' || '' }} - if: '${{ inputs.skip_packages }}' name: 'Publish all packages EXCEPT ${{ inputs.skip_packages }}' run: | @@ -94,14 +94,14 @@ jobs: --skipTests \ --tags=${{ inputs.dist_tag }} \ --skipPackages=${{ inputs.skip_packages }} ${{ (inputs.dry && '') || '\'}} - ${{ inputs.dry && '--dry'}} + ${{ inputs.dry && '--dry' || '' }} - if: '${{ !(inputs.skip_packages && inputs.only_packages) }}' name: 'Publish all packages' run: | scripts/release/publish.js \ --ci \ --tags=${{ inputs.dist_tag }} ${{ (inputs.dry && '') || '\'}} - ${{ inputs.dry && '--dry'}} + ${{ inputs.dry && '--dry' || '' }} - name: Notify Discord on failure if: failure() && inputs.enableFailureNotification == true uses: tsickert/discord-webhook@86dc739f3f165f16dadc5666051c367efa1692f4 diff --git a/.github/workflows/runtime_releases_from_npm_manual.yml b/.github/workflows/runtime_releases_from_npm_manual.yml index 51e38439553de..f164e9f080660 100644 --- a/.github/workflows/runtime_releases_from_npm_manual.yml +++ b/.github/workflows/runtime_releases_from_npm_manual.yml @@ -110,7 +110,7 @@ jobs: --tags=${{ inputs.tags }} \ --publishVersion=${{ inputs.version_to_publish }} \ --onlyPackages=${{ inputs.only_packages }} ${{ (inputs.dry && '') || '\'}} - ${{ inputs.dry && '--dry'}} + ${{ inputs.dry && '--dry' || '' }} - if: '${{ inputs.skip_packages }}' name: 'Publish all packages EXCEPT ${{ inputs.skip_packages }}' run: | @@ -119,7 +119,7 @@ jobs: --tags=${{ inputs.tags }} \ --publishVersion=${{ inputs.version_to_publish }} \ --skipPackages=${{ inputs.skip_packages }} ${{ (inputs.dry && '') || '\'}} - ${{ inputs.dry && '--dry'}} + ${{ inputs.dry && '--dry' || '' }} - name: Archive released package for debugging uses: actions/upload-artifact@v4 with: From 30f00e0eec5ed2f3367def1b852efa80ef362092 Mon Sep 17 00:00:00 2001 From: Sebastian Sebbie Silbermann Date: Fri, 20 Jun 2025 09:48:04 +0200 Subject: [PATCH 2/3] REVERT OR YOU WILL BE FIRED test this branch --- .github/workflows/runtime_prereleases_manual.yml | 4 ++-- .github/workflows/runtime_prereleases_nightly.yml | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/runtime_prereleases_manual.yml b/.github/workflows/runtime_prereleases_manual.yml index 407d931e90738..0d8e2bb522349 100644 --- a/.github/workflows/runtime_prereleases_manual.yml +++ b/.github/workflows/runtime_prereleases_manual.yml @@ -52,7 +52,7 @@ jobs: publish_prerelease_canary: if: ${{ !inputs.experimental_only }} name: Publish to Canary channel - uses: facebook/react/.github/workflows/runtime_prereleases.yml@main + uses: facebook/react/.github/workflows/runtime_prereleases.yml@sebbie/fix-wet-release permissions: # We use github.token to download the build artifact from a previous runtime_build_and_test.yml run actions: read @@ -79,7 +79,7 @@ jobs: publish_prerelease_experimental: name: Publish to Experimental channel - uses: facebook/react/.github/workflows/runtime_prereleases.yml@main + uses: facebook/react/.github/workflows/runtime_prereleases.yml@sebbie/fix-wet-release permissions: # We use github.token to download the build artifact from a previous runtime_build_and_test.yml run actions: read diff --git a/.github/workflows/runtime_prereleases_nightly.yml b/.github/workflows/runtime_prereleases_nightly.yml index f13a92e46f401..adcbf0692fba4 100644 --- a/.github/workflows/runtime_prereleases_nightly.yml +++ b/.github/workflows/runtime_prereleases_nightly.yml @@ -13,7 +13,7 @@ env: jobs: publish_prerelease_canary: name: Publish to Canary channel - uses: facebook/react/.github/workflows/runtime_prereleases.yml@main + uses: facebook/react/.github/workflows/runtime_prereleases.yml@sebbie/fix-wet-release permissions: # We use github.token to download the build artifact from a previous runtime_build_and_test.yml run actions: read @@ -30,7 +30,7 @@ jobs: publish_prerelease_experimental: name: Publish to Experimental channel - uses: facebook/react/.github/workflows/runtime_prereleases.yml@main + uses: facebook/react/.github/workflows/runtime_prereleases.yml@sebbie/fix-wet-release permissions: # We use github.token to download the build artifact from a previous runtime_build_and_test.yml run actions: read From 147f224873d727279abadf299bca2d3d44686f8e Mon Sep 17 00:00:00 2001 From: Sebastian Sebbie Silbermann Date: Fri, 20 Jun 2025 09:52:46 +0200 Subject: [PATCH 3/3] Revert "REVERT OR YOU WILL BE FIRED test this branch" This reverts commit 30f00e0eec5ed2f3367def1b852efa80ef362092. --- .github/workflows/runtime_prereleases_manual.yml | 4 ++-- .github/workflows/runtime_prereleases_nightly.yml | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/runtime_prereleases_manual.yml b/.github/workflows/runtime_prereleases_manual.yml index 0d8e2bb522349..407d931e90738 100644 --- a/.github/workflows/runtime_prereleases_manual.yml +++ b/.github/workflows/runtime_prereleases_manual.yml @@ -52,7 +52,7 @@ jobs: publish_prerelease_canary: if: ${{ !inputs.experimental_only }} name: Publish to Canary channel - uses: facebook/react/.github/workflows/runtime_prereleases.yml@sebbie/fix-wet-release + uses: facebook/react/.github/workflows/runtime_prereleases.yml@main permissions: # We use github.token to download the build artifact from a previous runtime_build_and_test.yml run actions: read @@ -79,7 +79,7 @@ jobs: publish_prerelease_experimental: name: Publish to Experimental channel - uses: facebook/react/.github/workflows/runtime_prereleases.yml@sebbie/fix-wet-release + uses: facebook/react/.github/workflows/runtime_prereleases.yml@main permissions: # We use github.token to download the build artifact from a previous runtime_build_and_test.yml run actions: read diff --git a/.github/workflows/runtime_prereleases_nightly.yml b/.github/workflows/runtime_prereleases_nightly.yml index adcbf0692fba4..f13a92e46f401 100644 --- a/.github/workflows/runtime_prereleases_nightly.yml +++ b/.github/workflows/runtime_prereleases_nightly.yml @@ -13,7 +13,7 @@ env: jobs: publish_prerelease_canary: name: Publish to Canary channel - uses: facebook/react/.github/workflows/runtime_prereleases.yml@sebbie/fix-wet-release + uses: facebook/react/.github/workflows/runtime_prereleases.yml@main permissions: # We use github.token to download the build artifact from a previous runtime_build_and_test.yml run actions: read @@ -30,7 +30,7 @@ jobs: publish_prerelease_experimental: name: Publish to Experimental channel - uses: facebook/react/.github/workflows/runtime_prereleases.yml@sebbie/fix-wet-release + uses: facebook/react/.github/workflows/runtime_prereleases.yml@main permissions: # We use github.token to download the build artifact from a previous runtime_build_and_test.yml run actions: read