Skip to content
This repository was archived by the owner on Feb 6, 2023. It is now read-only.

Commit e8a281c

Browse files
Claudio Procidafacebook-github-bot
authored andcommitted
Upgrades flow-bin to 0.91.0 and mutes fbjs joinClasses error � (#1989)
Summary: **Summary** Fixes a CI build error (#1988) by adding a `$FlowExpectedError` annotation, and upgrading [flow-bin](https://www.npmjs.com/package/flow-bin) to 0.91.0 **Test Plan** ``` yarn run flow flow src ``` ``` → flow src The flow server's version didn't match the client's, so it exited. Going to launch a new one. Launching Flow server for /Users/procidac/Development/gh/claudiopro/draft-js/src Spawned flow server (pid=87525) Logs will go to /private/tmp/flow/zSUserszSprocidaczSDevelopmentzSghzSclaudioprozSdraft-jszSsrc.log Monitor logs will go to /private/tmp/flow/zSUserszSprocidaczSDevelopmentzSghzSclaudioprozSdraft-jszSsrc.monitor_log No errors! ``` Pull Request resolved: #1989 Reviewed By: pakoito Differential Revision: D13917267 Pulled By: pakoito fbshipit-source-id: ce66ee4c67c4e7cc46c51ca91a4ade3d980fdf2e
1 parent c022efb commit e8a281c

File tree

6 files changed

+10
-8
lines changed

6 files changed

+10
-8
lines changed

meta/bundle-size-stats/Draft.js.json

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

meta/bundle-size-stats/Draft.min.js.json

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@
5858
"eslint-plugin-react": "^7.3.0",
5959
"eslint-plugin-relay": "^0.0.8",
6060
"fbjs-scripts": "^0.8.0",
61-
"flow-bin": "^0.70.0",
61+
"flow-bin": "^0.92.0",
6262
"gulp": "^4.0.0",
6363
"gulp-babel": "^6.1.2",
6464
"gulp-browserify-thin": "^0.1.5",

src/.flowconfig

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,8 @@ module.system.haste.paths.blacklist=.*/node_modules/invariant/.*
3333
esproposal.class_static_fields=enable
3434
suppress_type=$FlowIssue
3535
suppress_comment=\\(.\\|\n\\)*\\$FlowFixMe\\($\\|[^(]\\|(\\(>=0\\.\\(2[0-8]\\|1[0-9]\\|[0-9]\\).[0-9]\\)? *\\).*\n
36+
suppress_comment=\\(.\\|\n\\)*\\$FlowExpectedError
3637
module.name_mapper='ReactDOM' -> 'react-dom'
3738

3839
[version]
39-
^0.70.0
40+
^0.92.0

src/component/contents/DraftEditorContents-core.react.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -197,6 +197,7 @@ class DraftEditorContents extends React.Component<Props> {
197197
lastWrapperTemplate !== wrapperTemplate ||
198198
currentDepth === null ||
199199
depth > currentDepth;
200+
// $FlowExpectedError joinClasses args in [email protected] are incorrect
200201
className = joinClasses(
201202
className,
202203
getListItemClasses(blockType, depth, shouldResetCount, direction),

yarn.lock

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2619,10 +2619,10 @@ flat-cache@^1.2.1:
26192619
graceful-fs "^4.1.2"
26202620
write "^0.2.1"
26212621

2622-
flow-bin@^0.70.0:
2623-
version "0.70.0"
2624-
resolved "https://registry.yarnpkg.com/flow-bin/-/flow-bin-0.70.0.tgz#080ae83a997f2b4ddb3dc2649bf13336825292b5"
2625-
integrity sha1-CAroOpl/K03bPcJkm/EzNoJSkrU=
2622+
flow-bin@^0.92.0:
2623+
version "0.92.0"
2624+
resolved "https://registry.yarnpkg.com/flow-bin/-/flow-bin-0.92.0.tgz#f5bf3e808b17b480e067ac673829ca715a168bea"
2625+
integrity sha512-3ErXSAXZZlLV5/QPlaUDCWlDUXop1SiH32ifXL3SEiBwsmGbudCLim+HFVZfkegrn1nB4TcNSkMWtW8SnMPyAQ==
26262626

26272627
flush-write-stream@^1.0.0:
26282628
version "1.0.2"

0 commit comments

Comments
 (0)