chore: update pom.xml for improved formatting and add JDK 8+ profile (#432)

* chore: update pom.xml for improved formatting and add JDK 9+ profile

* chore: update pom.xml for improved formatting and add JDK 9+ profile

* chore: update pom.xml to use variable for argLine configuration

* chore: update pom.xml to use variable for argLine configuration

* chore: update pom.xml to use variable for argLine configuration

* chore: update pom.xml to skip tests and add file encoding to surefireArgLine

* chore: update pom.xml to enable tests and modify JDK profiles

* chore: update pom.xml to enable tests and modify JDK profiles

* Apply suggestion from @tisonkun

Co-authored-by: tison <[email protected]>

* Apply suggestion from @tisonkun

Co-authored-by: tison <[email protected]>

---------

Co-authored-by: tison <[email protected]>

Author: psxjoy

.github/workflows/ci.yml

@@ -55,11 +55,7 @@ jobs:
           restore-keys: |
             ${{ runner.os }}-m2
       - name: Test with Maven
-        if: ${{ matrix.java == '8' }}
         run: ./mvnw test -B -Dmaven.test.skip=false
-      - name: Test with Maven
-        if: ${{ matrix.java != '8' }}
-        run: ./mvnw test -B -Dmaven.test.skip=false -DargLine="--add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.base/sun.reflect.annotation=ALL-UNNAMED"
       - name: Publish Unit Test Results
         uses: EnricoMi/publish-unit-test-result-action@v2
         if: (!cancelled())

pom.xml

@@ -228,7 +228,9 @@
                     <artifactId>maven-surefire-plugin</artifactId>
                     <version>${maven-surefire-plugin.version}</version>
                     <configuration>
-                        <argLine>${argLine} -Dfile.encoding=UTF-8</argLine>
+                        <argLine>
+                            ${argLine} ${surefireArgLine}
+                        </argLine>
                     </configuration>
                     <!--                    please add below configuration if you are using JDK 9 or higher-->
                     <!--                    <configuration>-->
@@ -413,8 +415,8 @@
                         </indent>
                     </java>
                     <pom>
-                        <trimTrailingWhitespace />
-                        <endWithNewline />
+                        <trimTrailingWhitespace/>
+                        <endWithNewline/>
                         <indent>
                             <spaces>true</spaces>
                             <spacesPerTab>4</spacesPerTab>
@@ -445,4 +447,24 @@
             </plugin>
         </plugins>
     </build>
+    <profiles>
+        <profile>
+            <id>jdk9plus</id>
+            <activation>
+                <jdk>[9,)</jdk>
+            </activation>
+            <properties>
+                    <surefireArgLine>--add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.base/sun.reflect.annotation=ALL-UNNAMED -Dfile.encoding=UTF-8</surefireArgLine>
+            </properties>
+        </profile>
+        <profile>
+            <id>jdk8</id>
+            <activation>
+                <jdk>1.8</jdk>
+            </activation>
+            <properties>
+                <surefireArgLine> -Dfile.encoding=UTF-8</surefireArgLine>
+            </properties>
+        </profile>
+    </profiles>
 </project>