fix: add shared guard to prevent zero pricing

[entuziaz]

Fixes #38. Prevents zero pricePerTiBPerEpoch in capacity and storage calculations.

• Introduced assertPriceNonZero() in core/utils/validate-pricing.ts
• Integrated into calculateActualCapacity() and calculateStorageFromUSDFC()
• Updated tests to expect throws on zero pricing
• Prevents Infinity / unsafe deposit calculations

Changes

• Added core/utils/validate-pricing.ts with assertPriceNonZero()
• Integrated guard into:
  • calculateActualCapacity()
  • calculateStorageFromUSDFC()
• Updated unit tests to expect errors instead of silent 0-capacity returns.

Check this out @SgtPooki.

[SgtPooki]

Lgtm but needs a rebase?

[entuziaz]

Lgtm but needs a rebase?

Aye aye, sir!
Done, @SgtPooki.

[Copilot]

Pull Request Overview

This PR addresses issue #38 by adding input validation to prevent zero pricing values from causing division-by-zero errors or producing unsafe capacity calculations. The solution introduces a shared validation guard function that is integrated into capacity calculation functions.

Key changes:

• Added assertPriceNonZero() validation utility that throws on zero or negative pricing
• Replaced silent zero-price handling with explicit error throwing in calculateActualCapacity() and calculateStorageFromUSDFC()
• Updated tests to verify error throwing behavior instead of expecting silent zero returns

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
src/core/utils/validate-pricing.ts	New validation utility module with assertPriceNonZero() function
src/core/payments/index.ts	Integrated validation guard into two capacity calculation functions, removing previous zero-price checks
src/test/unit/payments-setup.test.ts	Added tests for validation function and updated existing tests to expect thrown errors

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[SgtPooki]

@entuziaz looks like you need to run npm run lint:fix on your code, see https://github.com/filecoin-project/filecoin-pin/actions/runs/19337489097/job/55344993018?pr=237

[entuziaz]

@entuziaz looks like you need to run npm run lint:fix on your code, see https://github.com/filecoin-project/filecoin-pin/actions/runs/19337489097/job/55344993018?pr=237

Done, @SgtPooki