Fix: Fixed issue where context menu icons wouldn't load in archives or FTP servers (#13238)

Author: hishitetsu

src/Files.App/Helpers/MenuFlyout/ContextFlyoutItemHelper.cs

@@ -561,10 +561,16 @@ public static List<ContextMenuFlyoutItemViewModel> GetBaseItemMenuItems(
 					ShowItem = isDriveRoot,
 					IsEnabled = false
 				},
+				// Shell extensions are not available on the FTP server or in the archive,
+				// but following items are intentionally added because icons in the context menu will not appear
+				// unless there is at least one menu item with an icon that is not an OpacityIcon. (#12943)
 				new ContextMenuFlyoutItemViewModel()
 				{
 					ItemType = ContextMenuFlyoutItemType.Separator,
 					Tag = "OverflowSeparator",
+					ShowInFtpPage = true,
+					ShowInZipPage = true,
+					ShowInRecycleBin = true,
 					ShowInSearchPage = true,
 				},
 				new ContextMenuFlyoutItemViewModel()
@@ -574,6 +580,8 @@ public static List<ContextMenuFlyoutItemViewModel> GetBaseItemMenuItems(
 					Items = new List<ContextMenuFlyoutItemViewModel>(),
 					ID = "ItemOverflow",
 					Tag = "ItemOverflow",
+					ShowInFtpPage = true,
+					ShowInZipPage = true,
 					ShowInRecycleBin = true,
 					ShowInSearchPage = true,
 					IsEnabled = false

src/Files.App/Views/LayoutModes/BaseLayout.cs

@@ -605,14 +605,18 @@ public async void BaseContextFlyout_Opening(object? sender, object e)
 				secondaryElements.OfType<FrameworkElement>().ForEach(i => i.MinWidth = Constants.UI.ContextMenuItemsMaxWidth);
 				secondaryElements.ForEach(i => BaseContextMenuFlyout.SecondaryCommands.Add(i));
 
-				if (!InstanceViewModel!.IsPageTypeSearchResults && !InstanceViewModel.IsPageTypeZipFolder)
+				if (!InstanceViewModel!.IsPageTypeSearchResults && !InstanceViewModel.IsPageTypeZipFolder && !InstanceViewModel.IsPageTypeFtp)
 				{
 					var shellMenuItems = await ContextFlyoutItemHelper.GetItemContextShellCommandsAsync(workingDir: ParentShellPageInstance.FilesystemViewModel.WorkingDirectory, selectedItems: new List<ListedItem>(), shiftPressed: shiftPressed, showOpenMenu: false, shellContextMenuItemCancellationToken.Token);
 					if (shellMenuItems.Any())
 						await AddShellMenuItemsAsync(shellMenuItems, BaseContextMenuFlyout, shiftPressed);
 					else
 						RemoveOverflow(BaseContextMenuFlyout);
 				}
+				else
+				{
+					RemoveOverflow(BaseContextMenuFlyout);
+				}
 			}
 			catch (Exception error)
 			{
@@ -667,14 +671,18 @@ private async Task LoadMenuItemsAsync()
 			if (InstanceViewModel!.CanTagFilesInPage)
 				AddNewFileTagsToMenu(ItemContextMenuFlyout);
 
-			if (!InstanceViewModel.IsPageTypeZipFolder)
+			if (!InstanceViewModel.IsPageTypeZipFolder && !InstanceViewModel.IsPageTypeFtp)
 			{
 				var shellMenuItems = await ContextFlyoutItemHelper.GetItemContextShellCommandsAsync(workingDir: ParentShellPageInstance.FilesystemViewModel.WorkingDirectory, selectedItems: SelectedItems!, shiftPressed: shiftPressed, showOpenMenu: false, shellContextMenuItemCancellationToken.Token);
 				if (shellMenuItems.Any())
 					await AddShellMenuItemsAsync(shellMenuItems, ItemContextMenuFlyout, shiftPressed);
 				else
 					RemoveOverflow(ItemContextMenuFlyout);
 			}
+			else
+			{
+				RemoveOverflow(ItemContextMenuFlyout);
+			}
 		}
 
 		private void AddCloseHandler(CommandBarFlyout flyout, IList<ICommandBarElement> primaryElements, IList<ICommandBarElement> secondaryElements)