Fix: Refactor smb credentials dialog logic (#11193)

Author: radu-cernatescu

src/Files.App/Helpers/NavigationHelpers.cs

@@ -251,7 +251,6 @@ private static async Task<FilesystemResult> OpenDirectory(string path, IShellPag
 			var opened = (FilesystemResult)false;
 			bool isHiddenItem = NativeFileOperationsHelper.HasFileAttribute(path, System.IO.FileAttributes.Hidden);
 			bool isShortcut = FileExtensionHelpers.IsShortcutOrUrlFile(path);
-			bool isNetwork = path.StartsWith(@"\\", StringComparison.Ordinal);
 
 			if (isShortcut)
 			{
@@ -271,27 +270,6 @@ private static async Task<FilesystemResult> OpenDirectory(string path, IShellPag
 				await OpenPath(forceOpenInNewTab, userSettingsService.FoldersSettingsService.OpenFoldersInNewTab, path, associatedInstance);
 				opened = (FilesystemResult)true;
 			}
-			else if (isNetwork)
-			{
-				var auth = await NetworkDrivesAPI.AuthenticateNetworkShare(path);
-				if (auth)
-				{
-					if (forceOpenInNewTab || userSettingsService.FoldersSettingsService.OpenFoldersInNewTab)
-					{
-						await OpenPathInNewTab(path);
-					}
-					else
-					{
-						associatedInstance.ToolbarViewModel.PathControlDisplayText = path;
-						associatedInstance.NavigateWithArguments(associatedInstance.InstanceViewModel.FolderSettings.GetLayoutType(path), new NavigationArguments()
-						{
-							NavPathParam = path,
-							AssociatedTabInstance = associatedInstance
-						});
-					}
-					opened = (FilesystemResult)true;
-				}
-			}
 			else
 			{
 				opened = await associatedInstance.FilesystemViewModel.GetFolderWithPathFromPathAsync(path)

src/Files.App/ViewModels/ItemViewModel.cs

@@ -1468,10 +1468,18 @@ public async Task<int> EnumerateItemsFromStandardFolderAsync(string path, Cancel
 		{
 			// Flag to use FindFirstFileExFromApp or StorageFolder enumeration - Use storage folder for Box Drive (#4629)
 			var isBoxFolder = App.CloudDrivesManager.Drives.FirstOrDefault(x => x.Text == "Box")?.Path?.TrimEnd('\\') is string boxFolder && path.StartsWith(boxFolder);
+			bool isNetwork = path.StartsWith(@"\\", StringComparison.Ordinal);
 			bool enumFromStorageFolder = isBoxFolder;
 
 			BaseStorageFolder? rootFolder = null;
 
+			if (isNetwork)
+			{
+				var auth = await NetworkDrivesAPI.AuthenticateNetworkShare(path);
+				if (!auth)
+					return -1;
+			}
+
 			if (!enumFromStorageFolder && FolderHelpers.CheckFolderAccessWithWin32(path))
 			{
 				// Will enumerate with FindFirstFileExFromApp, rootFolder only used for Bitlocker

src/Files.App/ViewModels/ToolbarViewModel.cs

@@ -1072,13 +1072,6 @@ public async Task CheckPathInput(string currentInput, string currentSelectedPath
 			if (currentInput.StartsWith('\\') && !currentInput.StartsWith("\\\\", StringComparison.Ordinal))
 				currentInput = currentInput.Insert(0, "\\");
 
-			if (currentInput.StartsWith('\\'))
-			{
-				var auth = await NetworkDrivesAPI.AuthenticateNetworkShare(currentInput);
-				if (!auth)
-					return;
-			}
-
 			if (currentSelectedPath == currentInput || string.IsNullOrWhiteSpace(currentInput))
 				return;