Fixed a crash that would sometimes occur when copying items to usb drives (#1780)

Author: gave92

Files/BaseLayout.cs

@@ -221,21 +221,22 @@ protected override async void OnNavigatedTo(NavigationEventArgs eventArgs)
             await App.CurrentInstance.FilesystemViewModel.SetWorkingDirectory(parameters);
 
             // pathRoot will be empty on recycle bin path
-            string pathRoot = Path.GetPathRoot(App.CurrentInstance.FilesystemViewModel.WorkingDirectory);
-            if (string.IsNullOrEmpty(pathRoot) || App.CurrentInstance.FilesystemViewModel.WorkingDirectory == pathRoot)
+            var workingDir = App.CurrentInstance.FilesystemViewModel.WorkingDirectory;
+            string pathRoot = Path.GetPathRoot(workingDir);
+            if (string.IsNullOrEmpty(pathRoot) || workingDir == pathRoot)
             {
                 App.CurrentInstance.NavigationToolbar.CanNavigateToParent = false;
             }
             else
             {
                 App.CurrentInstance.NavigationToolbar.CanNavigateToParent = true;
             }
+
             App.CurrentInstance.InstanceViewModel.IsPageTypeNotHome = true; // show controls that were hidden on the home page
-            App.CurrentInstance.InstanceViewModel.IsPageTypeRecycleBin =
-                App.CurrentInstance.FilesystemViewModel.WorkingDirectory.StartsWith(App.AppSettings.RecycleBinPath);
-            App.CurrentInstance.InstanceViewModel.IsPageTypeMtpDevice =
-                App.CurrentInstance.FilesystemViewModel.WorkingDirectory.StartsWith("\\\\?\\");
+            App.CurrentInstance.InstanceViewModel.IsPageTypeRecycleBin = workingDir.StartsWith(App.AppSettings.RecycleBinPath);
+            App.CurrentInstance.InstanceViewModel.IsPageTypeMtpDevice = workingDir.StartsWith("\\\\?\\");
 
+            await App.CurrentInstance.MultitaskingControl?.SetSelectedTabInfo(new DirectoryInfo(workingDir).Name, workingDir);
             App.CurrentInstance.FilesystemViewModel.RefreshItems();
 
             App.CurrentInstance.MultitaskingControl?.SelectionChanged();

Files/UserControls/MultitaskingControl/HorizontalMultitaskingControl.xaml.cs

@@ -9,6 +9,7 @@
 using System.Collections.ObjectModel;
 using System.IO;
 using System.Linq;
+using System.Threading.Tasks;
 using Windows.ApplicationModel.DataTransfer;
 using Windows.Storage;
 using Windows.UI.ViewManagement;
@@ -36,7 +37,7 @@ public HorizontalMultitaskingControl()
         private const string TabDropHandledIdentifier = "FilesTabViewItemDropHandled";
         public ObservableCollection<TabItem> Items => MainPage.AppInstances;
 
-        public async void SetSelectedTabInfo(string text, string currentPathForTabIcon)
+        public async Task SetSelectedTabInfo(string text, string currentPathForTabIcon)
         {
             var selectedTabItem = (MainPage.AppInstances[App.InteractionViewModel.TabStripSelectedIndex] as TabItem);
             selectedTabItem.AllowStorageItemDrop = App.CurrentInstance.InstanceViewModel.IsPageTypeNotHome;

Files/UserControls/MultitaskingControl/IMultitaskingControl.cs

@@ -1,10 +1,11 @@
 using System.Collections.ObjectModel;
+using System.Threading.Tasks;
 
 namespace Files.UserControls.MultiTaskingControl
 {
     public interface IMultitaskingControl
     {
-        void SetSelectedTabInfo(string text, string currentPathForTabIcon);
+        Task SetSelectedTabInfo(string text, string currentPathForTabIcon);
 
         void SelectionChanged();
 

Files/UserControls/MultitaskingControl/VerticalTabView.xaml.cs

@@ -8,6 +8,7 @@
 using System.Collections.ObjectModel;
 using System.IO;
 using System.Linq;
+using System.Threading.Tasks;
 using Windows.ApplicationModel.DataTransfer;
 using Windows.Storage;
 using Windows.UI.Xaml;
@@ -31,7 +32,7 @@ public VerticalTabView()
             this.InitializeComponent();
         }
 
-        public async void SetSelectedTabInfo(string text, string currentPathForTabIcon = null)
+        public async Task SetSelectedTabInfo(string text, string currentPathForTabIcon = null)
         {
             var selectedTabItem = (MainPage.AppInstances[App.InteractionViewModel.TabStripSelectedIndex] as TabItem);
             selectedTabItem.AllowStorageItemDrop = App.CurrentInstance.InstanceViewModel.IsPageTypeNotHome;

Files/View Models/ItemViewModel.cs

@@ -541,7 +541,6 @@ public async void RapidAddItemsToCollectionAsync(string path)
         {
             App.CurrentInstance.NavigationToolbar.CanRefresh = false;
 
-            App.CurrentInstance.MultitaskingControl?.SetSelectedTabInfo(new DirectoryInfo(path).Name, path);
             CancelLoadAndClearFiles();
 
             try