Use x:Load

Author: ferrariofilippo

src/Files.App/UserControls/Pane/PreviewPane.xaml

@@ -274,8 +274,9 @@
 				<!--  Tags List  -->
 				<StackPanel
 					x:Name="DetailsTagsList"
-					Spacing="4"
-					Visibility="Collapsed">
+					Margin="12,8,12,0"
+					x:Load="{x:Bind ViewModel.LoadTagsList, Mode=OneWay}"
+					Spacing="4">
 					<TextBlock
 						HorizontalAlignment="Stretch"
 						VerticalAlignment="Center"
@@ -363,7 +364,6 @@
 						<Setter Target="PreviewErrorText.Text" Value="{x:Bind GetLocalizedResource('DetailsPanePreviewNotAvaliableText')}" />
 						<Setter Target="FileDetailsRepeater.Visibility" Value="Visible" />
 						<Setter Target="DetailsEditTags.Visibility" Value="Visible" />
-						<Setter Target="DetailsTagsList.Visibility" Value="Visible" />
 						<Setter Target="DetailsListHeader.Visibility" Value="Visible" />
 						<Setter Target="PreviewControlPresenter.Visibility" Value="Collapsed" />
 					</VisualState.Setters>
@@ -377,7 +377,6 @@
 						<Setter Target="PreviewErrorText.Text" Value="{x:Bind GetLocalizedResource('DetailsPanePreviewNotAvaliableText')}" />
 						<Setter Target="FileDetailsRepeater.Visibility" Value="Collapsed" />
 						<Setter Target="DetailsEditTags.Visibility" Value="Collapsed" />
-						<Setter Target="DetailsTagsList.Visibility" Value="Collapsed" />
 						<Setter Target="PreviewControlPresenter.Visibility" Value="Collapsed" />
 					</VisualState.Setters>
 				</VisualState>
@@ -389,7 +388,6 @@
 						<Setter Target="PreviewErrorText.Visibility" Value="Collapsed" />
 						<Setter Target="FileDetailsRepeater.Visibility" Value="Visible" />
 						<Setter Target="DetailsEditTags.Visibility" Value="Visible" />
-						<Setter Target="DetailsTagsList.Visibility" Value="Visible" />
 						<Setter Target="PreviewControlPresenter.Visibility" Value="Visible" />
 						<Setter Target="DetailsListHeader.Visibility" Value="Visible" />
 					</VisualState.Setters>
@@ -402,7 +400,6 @@
 						<Setter Target="PreviewErrorText.Visibility" Value="Collapsed" />
 						<Setter Target="FileDetailsRepeater.Visibility" Value="Collapsed" />
 						<Setter Target="DetailsEditTags.Visibility" Value="Collapsed" />
-						<Setter Target="DetailsTagsList.Visibility" Value="Collapsed" />
 						<Setter Target="DetailsListHeader.Visibility" Value="Visible" />
 						<Setter Target="PreviewControlPresenter.Visibility" Value="Collapsed" />
 						<Setter Target="PreviewLoadingIndicator.Visibility" Value="Visible" />

src/Files.App/ViewModels/UserControls/PreviewPaneViewModel.cs

@@ -1,10 +1,9 @@
 // Copyright (c) 2023 Files Community
 // Licensed under the MIT License. See the LICENSE.
 
+using Files.App.Data.Contexts;
 using Files.App.UserControls.FilePreviews;
 using Files.App.ViewModels.Previews;
-using Files.Core.Helpers;
-using Files.Core.Utils.Cloud;
 using Microsoft.UI.Xaml;
 using Microsoft.UI.Xaml.Controls;
 using System.Windows.Input;
@@ -45,16 +44,29 @@ public ListedItem SelectedItem
 			get => selectedItem;
 			set
 			{
+				if (selectedItem is not null)
+					selectedItem.PropertyChanged -= SelectedItem_PropertyChanged;
+
 				if (SetProperty(ref selectedItem, value))
+				{
 					OnPropertyChanged(nameof(TagsFlyout));
+					OnPropertyChanged(nameof(LoadTagsList));
+
+					if (value is not null)
+						value.PropertyChanged += SelectedItem_PropertyChanged;
+				}
 			}
 		}
 
 		private PreviewPaneStates previewPaneState;
 		public PreviewPaneStates PreviewPaneState
 		{
 			get => previewPaneState;
-			set => SetProperty(ref previewPaneState, value);
+			set
+			{
+				if (SetProperty(ref previewPaneState, value))
+					OnPropertyChanged(nameof(LoadTagsList));
+			}
 		}
 
 		private bool showCloudItemButton;
@@ -71,6 +83,11 @@ public UIElement PreviewPaneContent
 			set => SetProperty(ref previewPaneContent, value);
 		}
 
+		public bool LoadTagsList
+			=> SelectedItem?.HasTags ?? false && 
+			PreviewPaneState is PreviewPaneStates.NoPreviewAvailable ||
+			PreviewPaneState is PreviewPaneStates.PreviewAndDetailsAvailable;
+
 		public MenuFlyout TagsFlyout
 			=> new Files.App.UserControls.Menus.FileTagsContextMenu(new List<ListedItem>() { SelectedItem });
 
@@ -353,6 +370,12 @@ private async Task LoadBasicPreviewAsync()
 			}
 		}
 
+		private void SelectedItem_PropertyChanged(object? sender, PropertyChangedEventArgs e)
+		{
+			if (e.PropertyName is nameof(ListedItem.HasTags))
+				OnPropertyChanged(nameof(LoadTagsList));
+		}
+
 		public void Dispose()
 		{
 			previewSettingsService.PropertyChanged -= PreviewSettingsService_OnPropertyChangedEvent;