Skip to content

Fix: Fixed NullReferenceException with OpenPropertiesWindow #13748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 9, 2023
Merged

Fix: Fixed NullReferenceException with OpenPropertiesWindow #13748

merged 3 commits into from
Nov 9, 2023

Conversation

@yaira2
Copy link
Member

@yaira2 yaira2 commented Nov 8, 2023

Resolved / Related Issues
https://appcenter.ms/orgs/FilesApp/apps/Files/crashes/errors/1504308570u/overview

Files.App.Utils.Storage
FilePropertiesHelpers.OpenPropertiesWindow (IShellPage associatedInstance)
Files.App.Actions
OpenPropertiesAction.ExecuteAsync ()

@yaira2 yaira2 added the ready for review Pull requests that are ready for review label Nov 8, 2023
hishitetsu
hishitetsu reviewed Nov 9, 2023
View reviewed changes
Copy link
Member

@hishitetsu hishitetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also consider the case where SlimContentPage or FilesystemViewModel is null.
The former should be treated as no items selected.

hishitetsu
hishitetsu reviewed Nov 9, 2023
View reviewed changes
hishitetsu
hishitetsu approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@hishitetsu hishitetsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 merged commit c41ec3d into main Nov 9, 2023
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Nov 9, 2023
@yaira2 yaira2 deleted the ya/OpenPropertiesWindow branch November 9, 2023 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@hishitetsu hishitetsu hishitetsu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yaira2 @hishitetsu